From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: [PATCH 2/2] Pakfire: do not leak upstream proxy password in log messages
Date: Sat, 11 Apr 2020 12:20:01 +0200 [thread overview]
Message-ID: <34570e9e-b21d-52aa-5cb1-8f6477feeae4@ipfire.org> (raw)
In-Reply-To: <6fd2993f-d022-9bd2-b3b7-5a60e974d9b6@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
---
src/pakfire/lib/functions.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
index 17a420c33..4d5c6219a 100644
--- a/src/pakfire/lib/functions.pl
+++ b/src/pakfire/lib/functions.pl
@@ -162,7 +162,7 @@ sub fetchfile {
logger("DOWNLOAD INFO: Upstream proxy: \"$proxysettings{'UPSTREAM_PROXY'}\"");
if ($proxysettings{'UPSTREAM_USER'}) {
$ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_USER'}:$proxysettings{'UPSTREAM_PASSWORD'}@"."$proxysettings{'UPSTREAM_PROXY'}/");
- logger("DOWNLOAD INFO: Logging in with: \"$proxysettings{'UPSTREAM_USER'}\" - \"$proxysettings{'UPSTREAM_PASSWORD'}\"");
+ logger("DOWNLOAD INFO: Logging in with \"$proxysettings{'UPSTREAM_USER'}\" against \"$proxysettings{'UPSTREAM_PROXY'}\"");
} else {
$ua->proxy(["http", "https"], "http://$proxysettings{'UPSTREAM_PROXY'}/");
}
--
2.16.4
next prev parent reply other threads:[~2020-04-11 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 10:19 [PATCH 1/2] Pakfire: fix upstream proxy usage Peter Müller
2020-04-11 10:20 ` Peter Müller [this message]
2020-04-11 10:44 ` [PATCH 2/2] Pakfire: do not leak upstream proxy password in log messages Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34570e9e-b21d-52aa-5cb1-8f6477feeae4@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox