From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] BUG12403: Change group permission of dma.conf Date: Wed, 13 May 2020 10:59:16 +0100 Message-ID: <3479F93E-C92E-429F-AFC2-0060C11F390E@ipfire.org> In-Reply-To: <027b8020-3a7e-5615-97b6-fc4101cc6335@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8404826856586386623==" List-Id: --===============8404826856586386623== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable By whom? > On 13 May 2020, at 10:54, Alexander Marx wrot= e: >=20 > very good point. This should be checked. >=20 >=20 > Am 13.05.20 um 10:29 schrieb Michael Tremer: >> Hi, >>=20 >> This solution looks a lot better to me. >>=20 >> Do we have to restore permissions when a backup is restored, too? >>=20 >> -Michael >>=20 >> Reviewed-by: Michael Tremer=20 >> >>=20 >>=20 >>=20 >>> On 13 May 2020, at 05:57, Alexander Marx >>> wrote: >>>=20 >>> Because other services that run as other users than nobody should be >>> able to send mails, this patch changes the permissions >>>=20 >>> from >>> nobody.root >>>=20 >>> to >>> nobody.mail >>>=20 >>> When another user wants to send mails via DMA, the user has to be put int= o the group "mail". >>>=20 >>> FIXES: #12403 >>>=20 >>> Arne: Please take care of update script, so these changes affect normal u= pdate procedure. >>> --- >>> lfs/dma | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>=20 >>> diff --git a/lfs/dma b/lfs/dma >>> index 6b5d9bfbf..7f0c2cc0e 100644 >>> --- a/lfs/dma >>> +++ b/lfs/dma >>> @@ -79,8 +79,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >>> cd $(DIR_APP) && make install mailq-link install-spool-dirs install-etc >>> install -v -m 755 $(DIR_SRC)/config/dma/dma-cleanup-spool /usr/sbin >>> chown -R nobody.nobody /var/ipfire/dma >>> - chown nobody.root /var/ipfire/dma/auth.conf >>> - chmod 644 /var/ipfire/dma/auth.conf >>> + chown nobody.mail /var/ipfire/dma/auth.conf >>> ln -svf dma /usr/sbin/sendmail.dma >>> /usr/sbin/alternatives --install /usr/sbin/sendmail sendmail /usr/sbin/s= endmail.dma 20 >>> @rm -rf $(DIR_APP) >>> --=20 >>> 2.17.1 >>>=20 >>>=20 >=20 --===============8404826856586386623==--