From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] unbound: speed-up remove forwarders Date: Tue, 03 Mar 2020 12:02:25 +0000 Message-ID: <34C76784-CF4B-4189-A200-606DA4DD3B0F@ipfire.org> In-Reply-To: <9dd401e2ace5d64c83145c0d04fadb03@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5599619141143550343==" List-Id: --===============5599619141143550343== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, No, we do not need to reload it. -Michael > On 2 Mar 2020, at 16:08, Arne Fitzenreiter wrote: >=20 > After thinking a bit more... >=20 > do we need to reload unbound at red down ? > It should make no difference if we simple remove this "remove forwarders" a= nd its call in red down. >=20 > Arne >=20 >=20 > Am 2020-03-02 17:02, schrieb Arne Fitzenreiter: >> Hi, >> i have no better Idea. >> unbound remove-forwarders not really remove the forwarders since last >> changes but >> it is called at red down so the initskript should exit after reload and no= t try >> to resolve any domains. >> Arne >> Am 2020-03-02 13:06, schrieb Michael Tremer: >>> Hi, >>> I am not entirely happy with the style of this fix, but it good enough >>> to be shipped as a hot fix for now. >>> I will have a look to remove too many steps during the reload phase >>> and that potentially includes finding another way how to handle Safe >>> Search. >>> Thanks for looking into this. >>> Best, >>> -Michael >>>> On 1 Mar 2020, at 19:41, Arne Fitzenreiter wrote: >>>> Signed-off-by: Arne Fitzenreiter >>>> --- >>>> src/initscripts/system/unbound | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> diff --git a/src/initscripts/system/unbound b/src/initscripts/system/unb= ound >>>> index b3185feab..0aab6cc8c 100644 >>>> --- a/src/initscripts/system/unbound >>>> +++ b/src/initscripts/system/unbound >>>> @@ -595,6 +595,10 @@ case "$1" in >>>> # Call unbound-control and perform the reload >>>> /usr/sbin/unbound-control -q reload >>>> + if [ "$1" =3D "remove-forwarders" ]; then >>>> + exit 0 >>>> + fi >>>> + >>>> # Dummy Resolve to wait for unbound >>>> resolve "ping.ipfire.org" &>/dev/null >>>> -- >>>> 2.17.1 --===============5599619141143550343==--