public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2 3/5] services.cgi: minor cosmetics
Date: Thu, 06 Oct 2022 20:52:43 +0200	[thread overview]
Message-ID: <34a7276c-689e-6619-d7d2-6b997fddeadc@ipfire.org> (raw)
In-Reply-To: <20221006175958.11036-4-robin.roevens@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 06.10.2022 um 19:59 schrieb Robin Roevens:
> * Singular 'Service' instead of plural 'Services' as column header of
>    services table
> * Sort list of services
> 
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
>   html/cgi-bin/services.cgi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index de946d755..e35b04cae 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){
>   <div align='center'>
>   <table width='80%' cellspacing='1' class='tbl'>
>   <tr>
> -	<th align='left'><b>$Lang::tr{'services'}</b></th>
> +	<th align='left'><b>$Lang::tr{'service'}</b></th>
>   	<th align='center' ><b>$Lang::tr{'status'}</b></th>
>   	<th align='center'><b>PID</b></th>
>   	<th align='center'><b>$Lang::tr{'memory'}</b></th>
> @@ -174,7 +174,7 @@ END
>   	# Generate list of installed addon pak services
>   	my %paklist = &Pakfire::dblist("installed");
>   
> -	foreach my $pak (keys %paklist) {
> +	foreach my $pak (sort keys %paklist) {
>   		my %metadata = &Pakfire::getmetadata($pak, "installed");
>   			
>   		my $service;

  reply	other threads:[~2022-10-06 18:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 17:59 [PATCH v2 0/5] Fix Bug#12935 + cosmetic changes/enhancements Robin Roevens
2022-10-06 17:59 ` [PATCH v2 1/5] misc-progs: addonctrl: Add support for 'Services' metadata Robin Roevens
2022-10-07 15:01   ` Michael Tremer
2022-10-08 23:09     ` Robin Roevens
2022-10-10 10:04       ` Michael Tremer
2022-10-10 12:27         ` Robin Roevens
2022-10-10 13:27           ` Michael Tremer
2022-10-06 17:59 ` [PATCH v2 2/5] services.cgi: Fix status/actions on services with name != addon name Robin Roevens
2022-10-06 17:59 ` [PATCH v2 3/5] services.cgi: minor cosmetics Robin Roevens
2022-10-06 18:52   ` Bernhard Bitsch [this message]
2022-10-06 17:59 ` [PATCH v2 4/5] services.cgi: add restart action and restrict action usage Robin Roevens
2022-10-06 17:59 ` [PATCH v2 5/5] services.cgi: add link to addon config if ui exists for it Robin Roevens
2022-10-06 18:48   ` Bernhard Bitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34a7276c-689e-6619-d7d2-6b997fddeadc@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox