From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH v2 3/5] services.cgi: minor cosmetics
Date: Thu, 06 Oct 2022 20:52:43 +0200
Message-ID: <34a7276c-689e-6619-d7d2-6b997fddeadc@ipfire.org>
In-Reply-To: <20221006175958.11036-4-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7308110080796289379=="
List-Id: <development.lists.ipfire.org>

--===============7308110080796289379==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 06.10.2022 um 19:59 schrieb Robin Roevens:
> * Singular 'Service' instead of plural 'Services' as column header of
>    services table
> * Sort list of services
> 
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
>   html/cgi-bin/services.cgi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index de946d755..e35b04cae 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){
>   <div align='center'>
>   <table width='80%' cellspacing='1' class='tbl'>
>   <tr>
> -	<th align='left'><b>$Lang::tr{'services'}</b></th>
> +	<th align='left'><b>$Lang::tr{'service'}</b></th>
>   	<th align='center' ><b>$Lang::tr{'status'}</b></th>
>   	<th align='center'><b>PID</b></th>
>   	<th align='center'><b>$Lang::tr{'memory'}</b></th>
> @@ -174,7 +174,7 @@ END
>   	# Generate list of installed addon pak services
>   	my %paklist = &Pakfire::dblist("installed");
>   
> -	foreach my $pak (keys %paklist) {
> +	foreach my $pak (sort keys %paklist) {
>   		my %metadata = &Pakfire::getmetadata($pak, "installed");
>   			
>   		my $service;

--===============7308110080796289379==--