From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH 2/6] crda: removal from kernel 4.15 and onwards. Date: Sun, 11 Jul 2021 13:29:40 +0200 Message-ID: <35320102-a76a-fd09-8190-b7ad6ae253ed@ipfire.org> In-Reply-To: <50a4b8b9-c369-4961-90a4-7cc0dff8370c@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2412603354373119490==" List-Id: --===============2412603354373119490== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi All, On 10/07/2021 13:17, Adolf Belka wrote: > Hi Arne, > > On 10/07/2021 09:25, Arne Fitzenreiter wrote: >> It's not hostapd itself. It's the cgi that use regdump to generate some li= sts. > Thanks for the clarification. >> There must be a way to get this list from wireless-regdb. Or we can genera= te and ship it. > I will have a look at this then and see if I can figure something out. > If I am unable to then someone else may need to have a go but I will try to= start with. > So my first thought was to build only regdbdump from the crda source tarball.= From the makefile it looked like you could run make regdbdump. When I tried = that I had an error but also it became clear it needed to have the python2 M2= crypto in place to do it, which we obviously don't want to do. A separate makefile could be made just to build regdbdump using a different c= rypto program that is in IPFire but all of that is way beyond my capabilities. A different option is that we could copy the db.txt from the wireless-regdb s= ource tarball to a location and then use that as the database source file for= wlanap.cgi. db.txt is the text based equivalent of what is in the regulatory= .bin file. A downside of that would be that we would not have the protection = of the key signed file but I am not sure if that would be a problem here or n= ot. We could always include a sha256 hash sum and use that to check that ther= e has been no corruption of the file before loading it into @countrylist_cmd = in wlanap.cgi What are the thoughts on my options above or on any additional options that I= have not thought of. Regards, Adolf. > Regards, > Adolf. >> >> Arne >> >> Am 2021-07-09 12:20, schrieb Adolf Belka: >>> Hi Arne, >>> >>> On 09/07/2021 08:26, Arne Fitzenreiter wrote: >>>> Removing regdump from crda package will break the hostapd webif because = this is used to >>>> generate the countrylist from wireless-regdb. >>> I thought things had gone too smoothly. Oh well. >>> >>> I have searched in the hostapd mail list for crda in the subject. >>> Nothing found all the way back to mid 2020 when there was a two year >>> break in any mails listed. >>> >>> I can't find any way to search the body of the mails for any mention >>> of crda and doing a google search for "hostapd crda" didn't flag >>> anything useful up. >>> >>> So I think I need to mail the hostapd list to see what their plans are >>> to not use crda (with its python2 dependency) in hostapd. >>> >>> Does anyone have any other thoughts on how to deal with this? >>> >>> Regards, >>> >>> Adolf. >>>> >>>> Arne >>>> >>>> Am 2021-06-28 21:13, schrieb Adolf Belka: >>>>> - From kernel 4.15 and onwards the function of what crda does is built >>>>> into the kernel. >>>>> - Tested the removal of crda with kernel 4.14.232 and kernel 5.10.45 >>>>> =C2=A0=C2=A0 Country code set by "iw reg set NL" was recognised with ke= rnel >>>>> 5.10.45 and set at >>>>> =C2=A0=C2=A0 the global value of 00 with kernel 4.14.232 confirming the= kernel >>>>> built in option is >>>>> =C2=A0=C2=A0 working without the prescence of crda >>>>> >>>>> Tested-by: Adolf Belka >>>>> Signed-off-by: Adolf Belka >>>>> --- >>>>> =C2=A0config/rootfiles/common/crda | 14 ------- >>>>> =C2=A0lfs/crda=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 78 --------= ---------------------------- >>>>> =C2=A02 files changed, 92 deletions(-) >>>>> =C2=A0delete mode 100644 config/rootfiles/common/crda >>>>> =C2=A0delete mode 100644 lfs/crda >>>>> >>>>> diff --git a/config/rootfiles/common/crda b/config/rootfiles/common/crda >>>>> deleted file mode 100644 >>>>> index 5f93bc254..000000000 >>>>> --- a/config/rootfiles/common/crda >>>>> +++ /dev/null >>>>> @@ -1,14 +0,0 @@ >>>>> -lib/udev/rules.d/85-regulatory.rules >>>>> -#root/.python-eggs >>>>> -#root/.python-eggs/M2Crypto-0.21.1-py2.7-linux-xxxMACHINExxx.egg-tmp >>>>> -#root/.python-eggs/M2Crypto-0.21.1-py2.7-linux-xxxMACHINExxx.egg-tmp/M= 2Crypto -#root/.python-eggs/M2Crypto-0.21.1-py2.7-linux-xxxMACHINExxx.egg-tmp= /M2Crypto/__m2crypto.so -sbin/crda >>>>> -sbin/regdbdump >>>>> -#usr/include/reglib >>>>> -#usr/include/reglib/nl80211.h >>>>> -#usr/include/reglib/regdb.h >>>>> -#usr/include/reglib/reglib.h >>>>> -usr/lib/libreg.so >>>>> -#usr/share/man/man8/crda.8.gz >>>>> -#usr/share/man/man8/regdbdump.8.gz >>>>> diff --git a/lfs/crda b/lfs/crda >>>>> deleted file mode 100644 >>>>> index bd812942e..000000000 >>>>> --- a/lfs/crda >>>>> +++ /dev/null >>>>> @@ -1,78 +0,0 @@ >>>>> -######################################################################= ######### -# =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# IPFire.org - A linux based firewall =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 # >>>>> -# Copyright (C) 2007-2018=C2=A0 IPFire Team =C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# This program is free software: you can redistribute it and/or modify= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# it under the terms of the GNU General Public License as published by= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# the Free Software Foundation, either version 3 of the License, or = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# (at your option) any later version. =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 # >>>>> -# =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# This program is distributed in the hope that it will be useful, =C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# but WITHOUT ANY WARRANTY; without even the implied warranty of =C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the =C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# GNU General Public License for more details. =C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 # >>>>> -# =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# You should have received a copy of the GNU General Public License = =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# along with this program.=C2=A0 If not, see .=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -# =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # >>>>> -######################################################################= ######### - >>>>> -######################################################################= ######### -# Definitions >>>>> -######################################################################= ######### - >>>>> -include Config >>>>> - >>>>> -VER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D 4.14 >>>>> - >>>>> -THISAPP=C2=A0=C2=A0=C2=A0 =3D crda-$(VER) >>>>> -DL_FILE=C2=A0=C2=A0=C2=A0 =3D $(THISAPP).tar.gz >>>>> -DL_FROM=C2=A0=C2=A0=C2=A0 =3D $(URL_IPFIRE) >>>>> -DIR_APP=C2=A0=C2=A0=C2=A0 =3D $(DIR_SRC)/$(THISAPP) >>>>> - >>>>> -TARGET =3D $(DIR_INFO)/$(THISAPP) >>>>> - >>>>> -######################################################################= ######### -# Top-level Rules >>>>> -######################################################################= ######### - >>>>> -objects =3D $(DL_FILE) >>>>> - >>>>> -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) >>>>> - >>>>> -$(DL_FILE)_MD5 =3D cac7ba8de3e2e6aa46918e0c76df7d67 >>>>> - >>>>> -install : $(TARGET) >>>>> - >>>>> -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) >>>>> - >>>>> -download :$(patsubst %,$(DIR_DL)/%,$(objects)) >>>>> - >>>>> -md5 : $(subst %,%_MD5,$(objects)) >>>>> - >>>>> -######################################################################= ######### -# Downloading, checking, md5sum >>>>> -######################################################################= ######### - >>>>> -$(patsubst %,$(DIR_CHK)/%,$(objects)) : >>>>> -=C2=A0=C2=A0=C2=A0 @$(CHECK) >>>>> - >>>>> -$(patsubst %,$(DIR_DL)/%,$(objects)) : >>>>> -=C2=A0=C2=A0=C2=A0 @$(LOAD) >>>>> - >>>>> -$(subst %,%_MD5,$(objects)) : >>>>> -=C2=A0=C2=A0=C2=A0 @$(MD5) >>>>> - >>>>> -######################################################################= ######### -# Installation Details >>>>> -######################################################################= ######### - >>>>> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) >>>>> -=C2=A0=C2=A0=C2=A0 @$(PREBUILD) >>>>> -=C2=A0=C2=A0=C2=A0 @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DI= R_DL)/$(DL_FILE) >>>>> -=C2=A0=C2=A0=C2=A0 cd $(DIR_APP) && sed -e "s/-Werror//g" -i Makefile >>>>> -=C2=A0=C2=A0=C2=A0 cd $(DIR_APP) && make $(MAKETUNING) >>>>> -=C2=A0=C2=A0=C2=A0 cd $(DIR_APP) && make install >>>>> -=C2=A0=C2=A0=C2=A0 @rm -rf $(DIR_APP) >>>>> -=C2=A0=C2=A0=C2=A0 @$(POSTBUILD) > --===============2412603354373119490==--