From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.haj.ipfire.org (localhost [127.0.0.1]) by mail02.haj.ipfire.org (Postfix) with ESMTP id 4Ztfk25CGcz32MJ for ; Thu, 8 May 2025 17:48:10 +0000 (UTC) Received: from mail01.ipfire.org (mail01.haj.ipfire.org [172.28.1.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail01.haj.ipfire.org", Issuer "R10" (verified OK)) by mail02.haj.ipfire.org (Postfix) with ESMTPS id 4Ztfjz21Vlz2xVX for ; Thu, 8 May 2025 17:48:07 +0000 (UTC) Received: from resqmta-a2p-658919.sys.comcast.net (resqmta-a2p-658919.sys.comcast.net [IPv6:2001:558:fd01:2bb4::8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail01.ipfire.org (Postfix) with ESMTPS id 4Ztfjw2qJ2z1yW for ; Thu, 8 May 2025 17:48:04 +0000 (UTC) Authentication-Results: mail01.ipfire.org; dkim=pass header.d=comcastmailservice.net header.s=20211018a header.b="KX/RyenW"; spf=none (mail01.ipfire.org: domain of stephen@firemypi.org has no SPF policy when checking 2001:558:fd01:2bb4::8) smtp.mailfrom=stephen@firemypi.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ipfire.org; s=202003rsa; t=1746726485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S5Vz7p4I3PEvSksyoMpdDWJRTK6vCsbsheVIFSRNjRc=; b=dKv0e/FdOtGpQBU0n5iSeJeOwpdsFHSmScjOT2PSqMSOnsrvYui3UJ5NT66pZxcYnCbrK3 dOXCjP4JVyPH/meDrw0slcjBZLiqueuWPcbQ00R6cwq/7q3vmOY6XScbv4TubRNT56nUej wM9/1Gj+TsWKLMhwzGMNdUwrg6IWtV49GQ7fba99ExZMq+qmy7k6Rv3ZBuwAeOWLDigcdq VnTSRYxIiAYsSEAXkpTlbkyNrzNzvEno5MnG71B1NCAjQvocxV4KYbG8V10Cd6bhaqBWK+ hyz/ezIrAGDJ7uceevdB4YJgCmKmzR+sRYJzMWi5L5cLUsua1e+xAZ3Za1Gq1A== ARC-Seal: i=1; s=202003rsa; d=lists.ipfire.org; t=1746726485; a=rsa-sha256; cv=none; b=Gxsx9wd9ofcmxf7PCbmT7hN4UVnfkWXj+g25u5qoxCX3adrnjYOMm0WxQRXJE1ucVJab8N QLSpu9R3j1Is38H1akcb+M+MeRkytnj9230qLr7bc+JdhQcoobeO2DaZmaVeYI4E4lr4Cq pHo4iC/YzYAlKNpRYo/fOIvNSH4nTLTWkTXwTJFaarO6on5c9OMQd9Jlu92zM+2pXuKq/l v0nkKRyIEWUI12GjqaChrACv151HCykLYh4ERbwVoFBcMNok/nOlPsSMmSAuDs8J5IDEA5 QxtC9gBynt1WvbDdAxHJVPK1qSnA6OLRyOOa5V5h4+pwFscyliuufhuCgre/xQ== ARC-Authentication-Results: i=1; mail01.ipfire.org; dkim=pass header.d=comcastmailservice.net header.s=20211018a header.b="KX/RyenW"; spf=none (mail01.ipfire.org: domain of stephen@firemypi.org has no SPF policy when checking 2001:558:fd01:2bb4::8) smtp.mailfrom=stephen@firemypi.org; dmarc=none Received: from resomta-a2p-647652.sys.comcast.net ([96.103.145.226]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 256/256 bits) (Client did not present a certificate) by resqmta-a2p-658919.sys.comcast.net with ESMTPS id D03UuWalZsUyTD5LiunIXm; Thu, 08 May 2025 17:47:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1746726479; bh=S5Vz7p4I3PEvSksyoMpdDWJRTK6vCsbsheVIFSRNjRc=; h=Received:Received:Message-ID:Date:MIME-Version:Subject:To:From: Content-Type:Xfinity-Spam-Result; b=KX/RyenWz6bUnhsmylohZQ3fnraNXaRDsMvUiEYEBjLxDjDDkl8CwrP/fr1E+M0/Z ZLHu2BBTKIWNPdl+sOsTYSI7vjRfktdE4K/Xo+u9XCtumjSnFPyI72YfiDZjoruI6Y 1PnmziLhiG5ezFqG+293IJv6mkk3DixvL63aIFbADYcp98z880nov9yg+jMDHJsQ+Q fmezaiyzuDNZU9NuLhLsZuFZsr8m6nYJ1EfahTRzoLCISRJ8OcN1UxwHpSaIuTzVSq ZmYVtuJyYjXGGBjq5TEy6KmepEwapzbq02em4zG+mk4lcRSMYjnESuC2t+Y9hGvmgN dujlEpFBoEmKQ== Received: from [192.168.3.30] ([75.70.122.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 256/256 bits) (Client did not present a certificate) by resomta-a2p-647652.sys.comcast.net with ESMTPSA id D5LguJbyJnbtfD5LhulQXJ; Thu, 08 May 2025 17:47:58 +0000 Message-ID: <3538ddfc-6119-428c-8ab9-86f75303b0a0@firemypi.org> Date: Thu, 8 May 2025 11:47:35 -0600 Precedence: list List-Id: List-Subscribe: , List-Unsubscribe: , List-Post: List-Help: Sender: Mail-Followup-To: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] functions.pl: Fix Bug13842 - Add resolvedeps to pakfire Usage:. To: Michael Tremer , stephen@firemypi.org Cc: "IPFire: Development-List" References: <20250423023903.144393-1-stephen@firemypi.org> <96b287c8-3639-4638-94c0-5f7e4cf33d6a@firemypi.org> Content-Language: en-US From: stephen@firemypi.org In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4xfMm9M1+OMtpFZ4X1eJNaacFiN2/DSnJFvc+ejCH5XKwMfCioG2x+1JrANtXofoaXwEKFcVJ099UDwzQR7DnW7inCl6PImyMg/3A5mcz+hwFPXtRWsI1A xWRnXN69HCI5plHXhFB1VP53vk/avGe+wiGa9Dwqyc4WMjNcGuFOyqSTgfb/M5uFWbA3PHeDUTF6py630Gv4VetvT1zkZrtFCVCGsgP3Lu8TAPRJqI6vIgGe DO70cdEiWqjZR69pQBpytSrjwQqoUdgfi0Tzxqx+PaQ= X-Rspamd-Server: mail01.haj.ipfire.org X-Rspamd-Queue-Id: 4Ztfjw2qJ2z1yW X-Spamd-Result: default: False [-5.17 / 11.00]; REPLY(-4.00)[]; HFILTER_HELO_5(3.00)[resqmta-a2p-658919.sys.comcast.net]; BAYES_HAM(-2.54)[97.94%]; NEURAL_HAM(-1.00)[-1.000]; IP_REPUTATION_HAM(-0.22)[asn: 7922(-0.21), country: US(-0.01), ip: 2001:558:fd01:2bb4::(0.00)]; R_DKIM_ALLOW(-0.20)[comcastmailservice.net:s=20211018a]; RCVD_IN_DNSWL_LOW(-0.10)[96.103.145.226:received]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; R_SPF_NA(0.00)[no SPF record]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DMARC_NA(0.00)[firemypi.org]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[75.70.122.243:received]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[comcastmailservice.net:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_REPUTATION(0.00)[0]; FROM_NO_DN(0.00)[]; ASN(0.00)[asn:7922, ipnet:2001:558::/29, country:US]; ARC_SIGNED(0.00)[lists.ipfire.org:s=202003rsa:i=1] X-Rspamd-Action: no action Hello Michael, I have never done a v2 patch.  I've seen them with [PATCHv2] in the heading.  I suspect that I would need to do something different with 'git format-patch' but not sure what.  Or is it as simple as editing the file created with 'git format-patch'? Regards, Stephen On 5/8/25 11:20, Michael Tremer wrote: > Hello Stephen, > > Yes, I am very happy with this change. It makes it very clear. > > Regarding the patch, what guidance do you need? > > -Michael > >> On 8 May 2025, at 17:49, stephen@firemypi.org wrote: >> >> Hello, >> >> I did some work on the Usage: text for pakfire to clean it up. Thanks Jon for your input. The revision is below. >> >> Should I submit this as a new patch or as one that overrides the previous bugfix patch? If it's preferable to do an overriding patch, I don't know how to do that so would need some guidance there. >> >> Regards, >> Stephen >> >> [root@zone3 ~]# pakfire >> Usage: pakfire COMMAND [OPTIONS] PACKAGE ... >> Manage IPFire add-on packages and updates. >> PACKAGE: >> One or more add-on package names. >> COMMAND: >> install - install one or more packages >> remove - remove one or more packages >> update - update the pakfire database >> upgrade - install latest version of all packages >> list [installed | notinstalled | upgrade] >> - display a list of installed, notinstalled, >> upgradeable or all packages >> info - display metadata for one or more packages >> resolvedeps - display dependencies for one or more packages >> status - display pakfire database status, >> available updates and whether a reboot >> is required to complete any upgrades >> OPTIONS: >> --no-colors - turn off colors >> -y | --non-interactive - automatic yes to prompts >> -f | --force - for the update command, force >> a pakfire database update >> >> [root@zone3 ~]# >> >> >> >> >> On 4/24/25 16:46, Jon Murphy wrote: >>> Sorry for the late suggestion! >>> >>> I cleaned up the pakfire help a little. It removes some of the leading spaces. >>> >>> >>> ``` >>> [root@ipfire ~] # pakfire >>> >>> Usage: >>> pakfire [option] … >>> >>> pakfire provides a safe and easy way to install add-ons and updates. >>> >>> Commands: >>> install [option] ... - install one or more packages >>> remove [option] ... - uninstall one or more packages >>> update - download new databases of packages >>> upgrade - install latest version of all packages >>> list [ --no-colors | installed | notinstalled | upgrade ] >>> - provides a list with all, installed, >>> available, or upgradeable packages >>> info ... - provides package metadata for one or >>> more packages >>> resolvedeps ... - provides a list of dependencies for >>> one or more packages >>> status - summary of available core upgrades, >>> updates, and a required reboot >>> >>> Options: >>> -y | --non-interactive - enables the non-interactive mode >>> --no-colors - turns off colors >>> ``` >>> >>> Feel free to use or feel free to ignore this. It is a suggestion. >>> >>> Jon >>> >>> >>> ------ Original Message ------ >>> From "Stephen Cuka" >>> To development@lists.ipfire.org >>> Cc "Stephen Cuka" >>> Date 4/22/2025 9:39:03 PM >>> Subject [PATCH] functions.pl: Fix Bug13842 - Add resolvedeps to pakfire Usage:. >>> >>>> - Add 'resolvedeps' command to pakfire 'Usage:'. >>>> >>>> - Break long lines in 'Usage:' so that they don't wrap. >>>> >>>> - Minor text and punctuation changes. >>>> >>>> Signed-off-by: Stephen Cuka >>>> --- >>>> src/pakfire/lib/functions.pl | 12 ++++++++---- >>>> 1 file changed, 8 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl >>>> index e623e8bc3..17b04ad52 100644 >>>> --- a/src/pakfire/lib/functions.pl >>>> +++ b/src/pakfire/lib/functions.pl >>>> @@ -112,11 +112,15 @@ sub logger { >>>> >>>> sub usage { >>>> &Pakfire::message("Usage: pakfire [options] "); >>>> - &Pakfire::message(" - Contacts the servers for new lists of paks."); >>>> - &Pakfire::message(" - Installs the latest version of all paks."); >>>> - &Pakfire::message(" [installed/notinstalled/upgrade] - Outputs a list with all, installed, available or upgradeable paks."); >>>> + &Pakfire::message(" - Contact the servers for new lists of paks."); >>>> + &Pakfire::message(" - Install the latest version of all paks."); >>>> + &Pakfire::message(" [installed|notinstalled|upgrade] - Output a list"); >>>> + &Pakfire::message(" of all, installed, available or upgradeable paks."); >>>> &Pakfire::message(" [ ...] - Output pak metadata."); >>>> - &Pakfire::message(" - Outputs a summary about available core upgrades, updates and a required reboot"); >>>> + &Pakfire::message(" [ ...] - Resolve and output pak"); >>>> + &Pakfire::message(" dependencies."); >>>> + &Pakfire::message(" - Output a summary of available core upgrades,"); >>>> + &Pakfire::message(" updates and a required reboot."); >>>> &Pakfire::message(""); >>>> &Pakfire::message(" Global options:"); >>>> &Pakfire::message(" --non-interactive --> Enables the non-interactive mode."); >>>> -- >>>> 2.43.0 >>>> >>>>