Re: [PATCH v3 3/5] services.cgi: minor cosmetics

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 11 Oct 2022, at 23:01, Robin Roevens <robin.roevens(a)disroot.org> wrote:
> 
> * Singular 'Service' instead of plural 'Services' as column header of
>  services table
> * Sort list of services
> 
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
> html/cgi-bin/services.cgi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index de946d755..e35b04cae 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -105,7 +105,7 @@ if ( $querry[0] =~ "processescpu"){
> <div align='center'>
> <table width='80%' cellspacing='1' class='tbl'>
> <tr>
> -	<th align='left'><b>$Lang::tr{'services'}</b></th>
> +	<th align='left'><b>$Lang::tr{'service'}</b></th>
> 	<th align='center' ><b>$Lang::tr{'status'}</b></th>
> 	<th align='center'><b>PID</b></th>
> 	<th align='center'><b>$Lang::tr{'memory'}</b></th>
> @@ -174,7 +174,7 @@ END
> 	# Generate list of installed addon pak services
> 	my %paklist = &Pakfire::dblist("installed");
> 
> -	foreach my $pak (keys %paklist) {
> +	foreach my $pak (sort keys %paklist) {
> 		my %metadata = &Pakfire::getmetadata($pak, "installed");
> 			
> 		my $service;
> -- 
> 2.37.3
> 
> 
> -- 
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>