From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Fischer To: development@lists.ipfire.org Subject: Re: [PATCH] BUG 11786 - squid: Remove setting for filter processes the number of Squid processes Date: Tue, 30 Oct 2018 15:37:14 +0100 Message-ID: <357c1cbd-36f5-e711-6cea-544ed00b5244@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6551450505175435092==" List-Id: --===============6551450505175435092== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On 30.10.2018 15:03, Michael Tremer wrote: > Hey, Hello, > do you have any idea why the redirector is busy? Sorry: no. Long time ago, I searched for an optimal value but didn't find any useful links. Right now, I'm testing 'squid 4.4" and its always the same. Too few redirectors =3D> warning. I only found something like "If you see this warning, you should increase the number of child processes and restart (or reconfigure) Squid. If the queue size becomes twice the number of redirectors, Squid aborts with a fatal message." Taken from: http://etutorials.org/Server+Administration/Squid.+The+definitive+guide/Chapt= er+11.+Redirectors/11.4+Configuring+Squid/ So my current "40"-value was found through "try and look if the warning comes again"... Best, Matthias > -Michael >=20 > On Tue, 2018-10-30 at 14:54 +0100, Matthias Fischer wrote: >> Hi, >>=20 >> I tested this patch today and I fear the resulting value is too low. >>=20 >> For me, its leads to: >>=20 >> ***SNIP*** >> ... >> 2018/10/30 14:42:43 kid1| WARNING: All 2/2 redirector processes are busy. >> 2018/10/30 14:42:43 kid1| WARNING: 4 pending requests queued >> 2018/10/30 14:42:43 kid1| WARNING: Consider increasing the number of >> redirector processes in your config file. >> ... >>=20 >> Current setting is "40" (Duo box, 2 Cores, 'squidclamav, squidguard) >>=20 >> Best, >> Matthias >>=20 >> On 30.10.2018 12:06, Daniel Weism=C3=BCller wrote: >> > I added a function to determine the number of cores. >> > Now the number of squid processes will be equal to the number of logical >> > cores. >> > Further I removed the possibility of changing the number >> > of squid processes in the proxy.cgi >> >=20 >> > Signed-off-by: Daniel Weism=C3=BCller >> > --- >> > config/cfgroot/general-functions.pl | 7 +++++++ >> > html/cgi-bin/proxy.cgi | 16 ++-------------- >> > 2 files changed, 9 insertions(+), 14 deletions(-) >> >=20 >> > diff --git a/config/cfgroot/general-functions.pl b/config/cfgroot/genera= l- >> > functions.pl >> > index 0577afe28..e8495e885 100644 >> > --- a/config/cfgroot/general-functions.pl >> > +++ b/config/cfgroot/general-functions.pl >> > @@ -1165,5 +1165,12 @@ sub dnssec_status() { >> > =20 >> > return $status; >> > } >> > +sub number_cpu_cores() { >> > + open my $cpuinfo, "/proc/cpuinfo" or die "Can't open cpuinfo: $!\n"; >> > + my $cores =3D scalar (map /^processor/, <$cpuinfo>); >> > + close $cpuinfo; >> > + >> > + return $cores; >> > +} >> > =20 >> > 1; >> > diff --git a/html/cgi-bin/proxy.cgi b/html/cgi-bin/proxy.cgi >> > index 738425b9a..92bebfe18 100644 >> > --- a/html/cgi-bin/proxy.cgi >> > +++ b/html/cgi-bin/proxy.cgi >> > @@ -287,7 +287,6 @@ $proxysettings{'IDENT_USER_ACL'} =3D 'positive'; >> > $proxysettings{'ENABLE_FILTER'} =3D 'off'; >> > $proxysettings{'ENABLE_UPDXLRATOR'} =3D 'off'; >> > $proxysettings{'ENABLE_CLAMAV'} =3D 'off'; >> > -$proxysettings{'CHILDREN'} =3D '10'; >> > =20 >> > $ncsa_buttontext =3D $Lang::tr{'advproxy NCSA create user'}; >> > =20 >> > @@ -437,11 +436,6 @@ if (($proxysettings{'ACTION'} eq $Lang::tr{'save'})= || >> > ($proxysettings{'ACTION'} >> > $errormessage =3D $Lang::tr{'invalid maximum incoming size'}; >> > goto ERROR; >> > } >> > - if (!($proxysettings{'CHILDREN'} =3D~ /^\d+$/) || >> > ($proxysettings{'CHILDREN'} < 1)) >> > - { >> > - $errormessage =3D $Lang::tr{'advproxy invalid num of children'}; >> > - goto ERROR; >> > - } >> > if ($proxysettings{'ENABLE_BROWSER_CHECK'} eq 'on') >> > { >> > $browser_regexp =3D ''; >> > @@ -1034,12 +1028,8 @@ print <> > >> >
>> > >> > - >> > - >> > END >> > ; >> > -my $count =3D `ip n| wc -l`; >> > -if ( $count < 1 ){$count =3D 1;} >> > if ( -e "/usr/bin/squidclamav" ) { >> > print ""; >> > } else { >> > print ""; >> > } >> > print ""; >> > print ""; >> > print <> >
$Lang::tr{'advproxy redirector >> > children'}
$Lang::tr{'processes'}: > > alt=3D'*' />> > value=3D'$proxysettings{'CHILDREN'}' size=3D'5' />".$Lang::tr{'advproxy squidclamav'}."=
> > />"; >> > if ( ! -e "/var/run/clamav/clamd.pid" ){ >> > @@ -1048,18 +1038,16 @@ if ( -e "/usr/bin/squidclamav" ) { >> > } >> > else { >> > print $Lang::tr{'advproxy enabled'}."> > name=3D'ENABLE_CLAMAV' ".$checked{'ENABLE_CLAMAV'}{'on'}." />
"; >> > - print "+ ".int(( $count**(1/3)) * 8);} >> > +} >> > print "		> > bin/urlfilter.cgi'>".$Lang::tr{'advproxy url filter'}."
= "; >> > print $Lang::tr{'advproxy enabled'}."> > name=3D'ENABLE_FILTER' ".$checked{'ENABLE_FILTER'}{'on'}." />
"; >> > -print "+ ".int(($count**(1/3)) * 6); >> > print "		> > bin/updatexlrator.cgi'>".$Lang::tr{'advproxy update >> > accelerator'}."
"; >> > print $Lang::tr{'advproxy enabled'}."> > name=3D'ENABLE_UPDXLRATOR' ".$checked{'ENABLE_UPDXLRATOR'}{'on'}." />"; >> > -print "+ ".int(($count**(1/3)) * 5); >> > print "
>> > @@ -4095,7 +4083,7 @@ END >> > if (($proxysettings{'ENABLE_FILTER'} eq 'on') || >> > ($proxysettings{'ENABLE_UPDXLRATOR'} eq 'on') || >> > ($proxysettings{'ENABLE_CLAMAV'} eq 'on')) >> > { >> > print FILE "url_rewrite_program /usr/sbin/redirect_wrapper\n"; >> > - print FILE "url_rewrite_children >> > $proxysettings{'CHILDREN'}\n\n"; >> > + print FILE "url_rewrite_children ", >> > &General::number_cpu_cores(), "\n\n"; >> > } >> > =20 >> > # Include file with user defined settings. >> >=20 >>=20 >>=20 >=20 >=20 --===============6551450505175435092==--