From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 6/9] pakfire: Add list upgrade functionality
Date: Mon, 21 Mar 2022 16:33:31 +0000
Message-ID: <35AD73A9-A670-4C18-9005-B30225FF5229@ipfire.org>
In-Reply-To: <20220309225655.4472-7-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8816310572104761891=="
List-Id: <development.lists.ipfire.org>

--===============8816310572104761891==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

> On 9 Mar 2022, at 22:56, Robin Roevens <robin.roevens(a)disroot.org> wrote:
>=20
> - Added possibility to list available upgrades from commandline
>  using 'pakfire list upgrade'.
> - Bugfix: allow [options] between 'list' and [installed/notinstalled/
>  upgrade]
>=20
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
> src/pakfire/lib/functions.pl |  2 +-
> src/pakfire/pakfire          | 14 +++++++++++++-
> 2 files changed, 14 insertions(+), 2 deletions(-)
>=20
> diff --git a/src/pakfire/lib/functions.pl b/src/pakfire/lib/functions.pl
> index 6287367f5..b35aed6a3 100644
> --- a/src/pakfire/lib/functions.pl
> +++ b/src/pakfire/lib/functions.pl
> @@ -114,7 +114,7 @@ sub usage {
>   &Pakfire::message("Usage: pakfire <install|remove> [options] <pak(s)>");
>   &Pakfire::message("               <update> - Contacts the servers for new=
 lists of paks.");
>   &Pakfire::message("               <upgrade> - Installs the latest version=
 of all paks.");
> -  &Pakfire::message("               <list> - Outputs a short list with all=
 available paks.");
> +  &Pakfire::message("               <list> [installed/notinstalled/upgrade=
] - Outputs a list with all, installed, available or upgradeable paks.");
>   &Pakfire::message("               <status> - Outputs a summary about avai=
lable core upgrades, updates and a required reboot");
>   &Pakfire::message("");
>   &Pakfire::message("       Global options:");
> diff --git a/src/pakfire/pakfire b/src/pakfire/pakfire
> index 2fb9adce7..b529db77a 100644
> --- a/src/pakfire/pakfire
> +++ b/src/pakfire/pakfire
> @@ -333,7 +333,9 @@
> 		my $reset_color =3D "";
> 		my $filter =3D "all";
>=20
> -		if ("$ARGV[1]" =3D~ /installed|notinstalled/) {
> +		shift if ("$ARGV[1]" =3D~ "^-");=20
> +
> +		if ("$ARGV[1]" =3D~ /installed|notinstalled|upgrade/) {
> 			$filter =3D "$ARGV[1]";
> 		} else {
> 			&Pakfire::message("PAKFIRE WARN: Not a known option $ARGV[1]") if ($ARGV=
[1]);=20
> @@ -347,6 +349,16 @@
> 			$use_color =3D "$Pakfire::color{'lightgreen'}";
> 		}
>=20
> +  		# Check for available core upgrade first if list of upgrades is reques=
ted
> +		if ("$filter" eq "upgrade") {
> +			my %coredb =3D &Pakfire::coredbinfo();
> +
> +			if (defined $coredb{'AvailableRelease'}) {
> +				print "${use_color}Core-Update $coredb{'CoreVersion'}\n";
> +				print "Release: $coredb{'Release'} -> $coredb{'AvailableRelease'}${res=
et_color}\n\n";
> +			}
> +		}

Here we should add an exit code, because monitoring people love them :)

> +
> 		foreach $pak (sort keys %paklist) {
> 			if ("$Pakfire::enable_colors" eq "1") {
> 				if ("$paklist{$pak}{'Installed'}" eq "yes") {
> --=20
> 2.34.1
>=20
>=20
> --=20
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>=20


--===============8816310572104761891==--