From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Confusing error message
Date: Sat, 14 Sep 2019 18:31:35 +0200
Message-ID: <35c1fbcf-90ff-e55c-8659-39ec385dc649@ipfire.org>
In-Reply-To: <20190914145621.GA14254@tarvainen.info>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5033568578983054476=="
List-Id: <development.lists.ipfire.org>

--===============5033568578983054476==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 14.09.2019 16:56, Tapani Tarvainen wrote:
> On Sat, Sep 14, 2019 at 03:55:00PM +0200, Matthias Fischer (matthias.fische=
r(a)ipfire.org) wrote:
>>=20
>> On 14.09.2019 15:29, Tapani Tarvainen wrote:
>> > I just spent a stupid amount of time trying to figure out why IpFire
>> > insisted a fixed lease had "invalid fixed ip address" when I could
>> > see nothing wrong with the address.
>> >=20
>> > I had to read the source before I realized where the problem was: the
>> > same error message is also used when the *next-server* address is bad,
>> > and it doesn't accept server name there but wants an IP.
>>=20
>> To be sure: do you mean this if-clause in 'dhcp.cgi'?
>>=20
>> ...
>>     if ($dhcpsettings{'FIX_NEXTADDR'}) {
>>         unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
>> $errormessage =3D $Lang::tr{'invalid fixed ip address'}; }
>>     }
>=20
> Exactly.
>=20
>> > I guess this would not be the most critical thing to fix but at least
>> > changing the error message would be nice.
>>=20
>> Yep. Should be easy.
>>=20
>> Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
>> be sufficient. I just need your confirmation.
>>=20
>> Would the errormessage 'invalid ip' =3D> 'Invalid IP Address' be clear
>> enough/sufficient?
>>=20
>> Alternative:
>> 'invalid next-server ip' =3D> 'Invalid IP Address for next-server'
>=20
> The latter is much better, as it makes it instantly clear *where* the
> error lies.

I tested with the update from above and found another check:

Adding the string "test" (without quotation marks) gives me:

Error messages
next-server on GREEN: Invalid IP Address

This is because of this (line ~220):

...
 if ($dhcpsettings{"NEXT_${itf}"}) {
   if (!(&General::validip($dhcpsettings{"NEXT_${itf}"}))) {
     $errormessage =3D "next-server on ${itf}: " . $Lang::tr{'invalid ip'};
      goto ERROR;
  }
...

Just for your information - we got *two* checks. ;-)

Best,
Matthias

--===============5033568578983054476==--