* Confusing error message
@ 2019-09-14 13:29 Tapani Tarvainen
2019-09-14 13:55 ` Matthias Fischer
0 siblings, 1 reply; 6+ messages in thread
From: Tapani Tarvainen @ 2019-09-14 13:29 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
I just spent a stupid amount of time trying to figure out why IpFire
insisted a fixed lease had "invalid fixed ip address" when I could
see nothing wrong with the address.
I had to read the source before I realized where the problem was: the
same error message is also used when the *next-server* address is bad,
and it doesn't accept server name there but wants an IP.
I guess this would not be the most critical thing to fix but at least
changing the error message would be nice.
--
Tapani Tarvainen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Confusing error message
2019-09-14 13:29 Confusing error message Tapani Tarvainen
@ 2019-09-14 13:55 ` Matthias Fischer
2019-09-14 14:02 ` Aw: " Bernhard Bitsch
2019-09-14 14:56 ` Tapani Tarvainen
0 siblings, 2 replies; 6+ messages in thread
From: Matthias Fischer @ 2019-09-14 13:55 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
Hi,
On 14.09.2019 15:29, Tapani Tarvainen wrote:
> I just spent a stupid amount of time trying to figure out why IpFire
> insisted a fixed lease had "invalid fixed ip address" when I could
> see nothing wrong with the address.
>
> I had to read the source before I realized where the problem was: the
> same error message is also used when the *next-server* address is bad,
> and it doesn't accept server name there but wants an IP.
To be sure: do you mean this if-clause in 'dhcp.cgi'?
...
if ($dhcpsettings{'FIX_NEXTADDR'}) {
unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
$errormessage = $Lang::tr{'invalid fixed ip address'}; }
}
...
> I guess this would not be the most critical thing to fix but at least
> changing the error message would be nice.
Yep. Should be easy.
Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
be sufficient. I just need your confirmation.
Would the errormessage 'invalid ip' => 'Invalid IP Address' be clear
enough/sufficient?
Alternative:
'invalid next-server ip' => 'Invalid IP Address for next-server'
Best,
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread* Aw: Re: Confusing error message
2019-09-14 13:55 ` Matthias Fischer
@ 2019-09-14 14:02 ` Bernhard Bitsch
2019-09-14 14:56 ` Tapani Tarvainen
1 sibling, 0 replies; 6+ messages in thread
From: Bernhard Bitsch @ 2019-09-14 14:02 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
Hi,
> Gesendet: Samstag, 14. September 2019 um 15:55 Uhr
> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
> An: development(a)lists.ipfire.org
> Betreff: Re: Confusing error message
>
> Hi,
>
> On 14.09.2019 15:29, Tapani Tarvainen wrote:
> > I just spent a stupid amount of time trying to figure out why IpFire
> > insisted a fixed lease had "invalid fixed ip address" when I could
> > see nothing wrong with the address.
> >
> > I had to read the source before I realized where the problem was: the
> > same error message is also used when the *next-server* address is bad,
> > and it doesn't accept server name there but wants an IP.
>
> To be sure: do you mean this if-clause in 'dhcp.cgi'?
>
> ...
> if ($dhcpsettings{'FIX_NEXTADDR'}) {
> unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
> $errormessage = $Lang::tr{'invalid fixed ip address'}; }
> }
> ...
>
> > I guess this would not be the most critical thing to fix but at least
> > changing the error message would be nice.
>
> Yep. Should be easy.
>
> Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
> be sufficient. I just need your confirmation.
>
> Would the errormessage 'invalid ip' => 'Invalid IP Address' be clear
> enough/sufficient?
>
> Alternative:
> 'invalid next-server ip' => 'Invalid IP Address for next-server'
>
I would prefer this version. The semantic "next-server must be a IP address" is expressed more clearly.
> Best,
> Matthias
>
Best,
Bernhard
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Confusing error message
2019-09-14 13:55 ` Matthias Fischer
2019-09-14 14:02 ` Aw: " Bernhard Bitsch
@ 2019-09-14 14:56 ` Tapani Tarvainen
2019-09-14 16:31 ` Matthias Fischer
1 sibling, 1 reply; 6+ messages in thread
From: Tapani Tarvainen @ 2019-09-14 14:56 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]
On Sat, Sep 14, 2019 at 03:55:00PM +0200, Matthias Fischer (matthias.fischer(a)ipfire.org) wrote:
>
> On 14.09.2019 15:29, Tapani Tarvainen wrote:
> > I just spent a stupid amount of time trying to figure out why IpFire
> > insisted a fixed lease had "invalid fixed ip address" when I could
> > see nothing wrong with the address.
> >
> > I had to read the source before I realized where the problem was: the
> > same error message is also used when the *next-server* address is bad,
> > and it doesn't accept server name there but wants an IP.
>
> To be sure: do you mean this if-clause in 'dhcp.cgi'?
>
> ...
> if ($dhcpsettings{'FIX_NEXTADDR'}) {
> unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
> $errormessage = $Lang::tr{'invalid fixed ip address'}; }
> }
Exactly.
> > I guess this would not be the most critical thing to fix but at least
> > changing the error message would be nice.
>
> Yep. Should be easy.
>
> Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
> be sufficient. I just need your confirmation.
>
> Would the errormessage 'invalid ip' => 'Invalid IP Address' be clear
> enough/sufficient?
>
> Alternative:
> 'invalid next-server ip' => 'Invalid IP Address for next-server'
The latter is much better, as it makes it instantly clear *where* the
error lies.
Thank you,
--
Tapani Tarvainen
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Confusing error message
2019-09-14 14:56 ` Tapani Tarvainen
@ 2019-09-14 16:31 ` Matthias Fischer
2019-09-14 18:09 ` Tom Rymes
0 siblings, 1 reply; 6+ messages in thread
From: Matthias Fischer @ 2019-09-14 16:31 UTC (permalink / raw)
To: development
[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]
Hi,
On 14.09.2019 16:56, Tapani Tarvainen wrote:
> On Sat, Sep 14, 2019 at 03:55:00PM +0200, Matthias Fischer (matthias.fischer(a)ipfire.org) wrote:
>>
>> On 14.09.2019 15:29, Tapani Tarvainen wrote:
>> > I just spent a stupid amount of time trying to figure out why IpFire
>> > insisted a fixed lease had "invalid fixed ip address" when I could
>> > see nothing wrong with the address.
>> >
>> > I had to read the source before I realized where the problem was: the
>> > same error message is also used when the *next-server* address is bad,
>> > and it doesn't accept server name there but wants an IP.
>>
>> To be sure: do you mean this if-clause in 'dhcp.cgi'?
>>
>> ...
>> if ($dhcpsettings{'FIX_NEXTADDR'}) {
>> unless(&General::validip($dhcpsettings{'FIX_NEXTADDR'})) {
>> $errormessage = $Lang::tr{'invalid fixed ip address'}; }
>> }
>
> Exactly.
>
>> > I guess this would not be the most critical thing to fix but at least
>> > changing the error message would be nice.
>>
>> Yep. Should be easy.
>>
>> Adjusting 'dhcp.cgi' and the 'lang'-string for the errormessage should
>> be sufficient. I just need your confirmation.
>>
>> Would the errormessage 'invalid ip' => 'Invalid IP Address' be clear
>> enough/sufficient?
>>
>> Alternative:
>> 'invalid next-server ip' => 'Invalid IP Address for next-server'
>
> The latter is much better, as it makes it instantly clear *where* the
> error lies.
I tested with the update from above and found another check:
Adding the string "test" (without quotation marks) gives me:
Error messages
next-server on GREEN: Invalid IP Address
This is because of this (line ~220):
...
if ($dhcpsettings{"NEXT_${itf}"}) {
if (!(&General::validip($dhcpsettings{"NEXT_${itf}"}))) {
$errormessage = "next-server on ${itf}: " . $Lang::tr{'invalid ip'};
goto ERROR;
}
...
Just for your information - we got *two* checks. ;-)
Best,
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-14 18:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-14 13:29 Confusing error message Tapani Tarvainen
2019-09-14 13:55 ` Matthias Fischer
2019-09-14 14:02 ` Aw: " Bernhard Bitsch
2019-09-14 14:56 ` Tapani Tarvainen
2019-09-14 16:31 ` Matthias Fischer
2019-09-14 18:09 ` Tom Rymes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox