From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] graphs.pl: Standardize localization strings for hardware graphs (ACPI)
Date: Sat, 05 Sep 2020 17:42:19 +0200 [thread overview]
Message-ID: <35f0320f-53ca-25df-6c40-56f4f3506c0c@ipfire.org> (raw)
In-Reply-To: <AF39439B-C70B-4367-B722-361519CED8C7@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2239 bytes --]
Hi,
On 24.08.2020 16:08, Michael Tremer wrote:
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>
>> On 22 Aug 2020, at 22:59, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>>
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>> config/cfgroot/graphs.pl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
>> index 9531a0e37..de306710e 100644
>> --- a/config/cfgroot/graphs.pl
>> +++ b/config/cfgroot/graphs.pl
>> @@ -1088,7 +1088,7 @@ sub updatethermaltempgraph {
>> "--start",
>> "-1".$period,
>> "-r",
>> - "-t "."ACPI Thermal-Zone Temperature"." - ".$Lang::tr{$period."-graph"},
>> + "-t "."ACPI Thermal-Zone Temperature"." ".$Lang::tr{'graph per'}." ".$Lang::tr{$period."-graph"},
>
> Can we have the ACPI Thermal Zone part translated, too? Maybe in a separate patch?
No problem, done - but:
While working on this, I found a bunch of other glitches. Besides, the
following patches weren't merged yet. Just cosmetic ones, but they
contain patches for 'hardwaregraphs.cgi' and 'netother.cgi' - among some
others.
Removed unnecessary translation string for 'graph' from several cgis:
https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=1851c3d59a6569a37aaf40af6ddee84d57f0d7bc
Removed obsolete translation string:
https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=5ec038119c78a49d586afdaf3dee6b4b23f47f1c
graphs.pl: Standardize localization strings for disk access graphs:
https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=9a3fba8661b76bc455e553cf9d39550d5ea919b2
graphs.pl: Standardize localization strings for hardware graphs (ACPI):
https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=b996e44f4d49724a46d35c71554ab854c42b7e96
graphs.pl: Standardize localization strings for entropy graphs:
https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=commit;h=ae5cf4304940f4b4648ef0b8582f6ddb770ac3cf
I'll send some patches based on "ms_conntrack", but in this way, only
two CGIs from the above patches are taken into account.
Can this be merged this way?
Best,
Matthias
next prev parent reply other threads:[~2020-09-05 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 21:59 Matthias Fischer
2020-08-24 14:08 ` Michael Tremer
2020-09-05 15:42 ` Matthias Fischer [this message]
2020-09-05 15:42 ` Matthias Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f0320f-53ca-25df-6c40-56f4f3506c0c@ipfire.org \
--to=matthias.fischer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox