From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] graphs.pl: Standardize localization strings for hardware
 graphs (ACPI)
Date: Sat, 05 Sep 2020 17:42:19 +0200
Message-ID: <35f0320f-53ca-25df-6c40-56f4f3506c0c@ipfire.org>
In-Reply-To: <AF39439B-C70B-4367-B722-361519CED8C7@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3434470954277266463=="
List-Id: <development.lists.ipfire.org>

--===============3434470954277266463==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On 24.08.2020 16:08, Michael Tremer wrote:
> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>=20
>> On 22 Aug 2020, at 22:59, Matthias Fischer <matthias.fischer(a)ipfire.org>=
 wrote:
>>=20
>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>> ---
>> config/cfgroot/graphs.pl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/config/cfgroot/graphs.pl b/config/cfgroot/graphs.pl
>> index 9531a0e37..de306710e 100644
>> --- a/config/cfgroot/graphs.pl
>> +++ b/config/cfgroot/graphs.pl
>> @@ -1088,7 +1088,7 @@ sub updatethermaltempgraph {
>> 		"--start",
>> 		"-1".$period,
>> 		"-r",
>> -		"-t "."ACPI Thermal-Zone Temperature"." - ".$Lang::tr{$period."-graph"},
>> +		"-t "."ACPI Thermal-Zone Temperature"." ".$Lang::tr{'graph per'}." ".$L=
ang::tr{$period."-graph"},
>=20
> Can we have the ACPI Thermal Zone part translated, too? Maybe in a separate=
 patch?

No problem, done - but:

While working on this, I found a bunch of other glitches. Besides, the
following patches weren't merged yet. Just cosmetic ones, but they
contain patches for 'hardwaregraphs.cgi' and 'netother.cgi' - among some
others.

Removed unnecessary translation string for 'graph' from several cgis:
https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dcommit;h=3D185=
1c3d59a6569a37aaf40af6ddee84d57f0d7bc

Removed obsolete translation string:
https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dcommit;h=3D5ec=
038119c78a49d586afdaf3dee6b4b23f47f1c

graphs.pl: Standardize localization strings for disk access graphs:
https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dcommit;h=3D9a3=
fba8661b76bc455e553cf9d39550d5ea919b2

graphs.pl: Standardize localization strings for hardware graphs (ACPI):
https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dcommit;h=3Db99=
6e44f4d49724a46d35c71554ab854c42b7e96

graphs.pl: Standardize localization strings for entropy graphs:
https://git.ipfire.org/?p=3Dpeople/mfischer/ipfire-2.x.git;a=3Dcommit;h=3Dae5=
cf4304940f4b4648ef0b8582f6ddb770ac3cf

I'll send some patches based on "ms_conntrack", but in this way, only
two CGIs from the above patches are taken into account.

Can this be merged this way?

Best,
Matthias

--===============3434470954277266463==--