From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] netother.cgi: show content of routing table 220
Date: Sun, 08 Mar 2020 11:42:08 +0000
Message-ID: <36253712-E143-4794-84DA-A74562317C38@ipfire.org>
In-Reply-To: <45750d21-4ee6-4269-c2b5-56ef4e75c259@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3776845344756733037=="
List-Id: <development.lists.ipfire.org>

--===============3776845344756733037==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

I appreciate the thought, but I think the implementation might be very confus=
ing.

I think the patch could be improved by:

* Removing the 220 number and simply call it =E2=80=9CIPsec VPN Routing Table=
=E2=80=9D

* Not show the box when the table is empty which it will be for all users tha=
t are not using IPsec

And since it is basically a static table, I do not see what there is to gain =
for the user from this. How can this help with debugging?

-Michael

> On 7 Mar 2020, at 18:46, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> Since IPsec routing information do not show up in the normal routing
> table, also displaying the contents of table 220 on netother.cgi might
> be useful for debugging purposes.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> html/cgi-bin/netother.cgi | 6 ++++++
> 1 file changed, 6 insertions(+)
>=20
> diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi
> index dde1b603a..ac02b8148 100644
> --- a/html/cgi-bin/netother.cgi
> +++ b/html/cgi-bin/netother.cgi
> @@ -79,6 +79,12 @@ if ( $querry[0] =3D~ "fwhits"){
> 	print "<pre>$output</pre>\n";
> 	&Header::closebox();
>=20
> +	&Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 220"=
);
> +	$output =3D `/sbin/ip route list table 220`;
> +	$output =3D &Header::cleanhtml($output,"y");
> +	print "<pre>$output</pre>\n";
> +	&Header::closebox()
> +
> 	&Header::openbox('100%', 'left', $Lang::tr{'arp table entries'});
> 	$output =3D `/sbin/ip neigh show`;
> 	$output =3D &Header::cleanhtml($output,"y");
> --=20
> 2.16.4


--===============3776845344756733037==--