From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] netother.cgi: show content of routing table 220
Date: Sun, 08 Mar 2020 13:35:49 +0000
Message-ID: <36EB6CA2-AC4A-4FE8-9357-01F8DAF745B4@ipfire.org>
In-Reply-To: <ed593e05-e25f-ec0a-9e9f-af55c44dc914@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8170663436177939048=="
List-Id: <development.lists.ipfire.org>

--===============8170663436177939048==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Okay. Will you update the patch accordingly, please?

-Michael

> On 8 Mar 2020, at 13:15, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wro=
te:
>=20
> Hello Michael,
>=20
>> Hi,
>>=20
>> I appreciate the thought, but I think the implementation might be very con=
fusing.
>>=20
>> I think the patch could be improved by:
>>=20
>> * Removing the 220 number and simply call it =E2=80=9CIPsec VPN Routing Ta=
ble=E2=80=9D
>=20
> Okay, good point.
>=20
>>=20
>> * Not show the box when the table is empty which it will be for all users =
that are not using IPsec
>=20
> ACK.
>=20
>>=20
>> And since it is basically a static table, I do not see what there is to ga=
in for the user from this. How can this help with debugging?
>=20
> For the same reasons we display contents of the routing table, I guess. The=
 user is
> able to do quick plausibility checks over it, without digging/using the sea=
rch
> engine of his/hers least distrust for the command that shows him the IPsec =
routing information.
>=20
> Thanks, and best regards,
> Peter M=C3=BCller
>=20
>>=20
>> -Michael
>>=20
>>> On 7 Mar 2020, at 18:46, Peter M=C3=BCller <peter.mueller(a)ipfire.org> w=
rote:
>>>=20
>>> Since IPsec routing information do not show up in the normal routing
>>> table, also displaying the contents of table 220 on netother.cgi might
>>> be useful for debugging purposes.
>>>=20
>>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>>> ---
>>> html/cgi-bin/netother.cgi | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>=20
>>> diff --git a/html/cgi-bin/netother.cgi b/html/cgi-bin/netother.cgi
>>> index dde1b603a..ac02b8148 100644
>>> --- a/html/cgi-bin/netother.cgi
>>> +++ b/html/cgi-bin/netother.cgi
>>> @@ -79,6 +79,12 @@ if ( $querry[0] =3D~ "fwhits"){
>>> 	print "<pre>$output</pre>\n";
>>> 	&Header::closebox();
>>>=20
>>> +	&Header::openbox('100%', 'left', "$Lang::tr{'routing table entries'} 22=
0");
>>> +	$output =3D `/sbin/ip route list table 220`;
>>> +	$output =3D &Header::cleanhtml($output,"y");
>>> +	print "<pre>$output</pre>\n";
>>> +	&Header::closebox()
>>> +
>>> 	&Header::openbox('100%', 'left', $Lang::tr{'arp table entries'});
>>> 	$output =3D `/sbin/ip neigh show`;
>>> 	$output =3D &Header::cleanhtml($output,"y");
>>> --=20
>>> 2.16.4
>>=20


--===============8170663436177939048==--