From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] pakfire.cgi: Give pakfire time to write lockfile when update/upgrade.
Date: Fri, 15 Oct 2021 11:33:38 +0200 [thread overview]
Message-ID: <36de2347d06cdfd86b4a82e492e918ed26f60c1e.camel@ipfire.org> (raw)
In-Reply-To: <20211012164240.3546-1-stefan.schantl@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]
Hello List,
after some more testing I had to decide to reject this patch from
beeing merged.
It simply does not work all the time, because may the sleep time is too
short if the system is busy, or pakfire needs to long to startup and
place the lockfile.
So I have to go back to the drawing board and do a better solution for
this issue.
Sorry for the noise on the list,
-Stefan
> In case the package list should be grabbed or the system should be
> upgraded, pakfire got called which writes a lock file to prevent from
> beeing launched multiple times and to lock the pakfire.cgi with the
> nice
> log output.
>
> In case update or upgrade has been performed via WUI, pakfire has
> been called
> and written the file in the background but the WUI script has been
> executed further and because of a race condition it did not recognize
> the lockfile at this moment because it was not present.
>
> So a simple sleep should to the trick and give pakfire the required
> time
> to write out it's lockfile.
>
> Fixes #12696.
>
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> html/cgi-bin/pakfire.cgi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
> index 0cf522ba1..aaf63d469 100644
> --- a/html/cgi-bin/pakfire.cgi
> +++ b/html/cgi-bin/pakfire.cgi
> @@ -133,8 +133,10 @@ END
>
> } elsif (($cgiparams{'ACTION'} eq 'update') && (! -e
> $Pakfire::lockfile)) {
> &General::system_background("/usr/local/bin/pakfire",
> "update", "--force", "--no-colors");
> + sleep(1);
> } elsif (($cgiparams{'ACTION'} eq 'upgrade') && (!-e
> $Pakfire::lockfile)) {
> &General::system_background("/usr/local/bin/pakfire",
> "upgrade", "-y", "--no-colors");
> + sleep(1);
> } elsif ($cgiparams{'ACTION'} eq "$Lang::tr{'save'}") {
> $pakfiresettings{"TREE"} = $cgiparams{"TREE"};
>
next prev parent reply other threads:[~2021-10-15 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 16:42 Stefan Schantl
2021-10-12 17:23 ` Peter Müller
2021-10-14 14:02 ` Michael Tremer
2021-10-15 9:33 ` Stefan Schantl [this message]
2021-10-15 10:14 ` Michael Tremer
2021-10-15 13:30 ` Tapani Tarvainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36de2347d06cdfd86b4a82e492e918ed26f60c1e.camel@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox