From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] pakfire.cgi: Give pakfire time to write lockfile when
 update/upgrade.
Date: Fri, 15 Oct 2021 11:33:38 +0200
Message-ID: <36de2347d06cdfd86b4a82e492e918ed26f60c1e.camel@ipfire.org>
In-Reply-To: <20211012164240.3546-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1645664773990023893=="
List-Id: <development.lists.ipfire.org>

--===============1645664773990023893==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

Hello List,

after some more testing I had to decide to reject this patch from
beeing merged.

It simply does not work all the time, because may the sleep time is too
short if the system is busy, or pakfire needs to long to startup and
place the lockfile.

So I have to go back to the drawing board and do a better solution for
this issue.

Sorry for the noise on the list,

-Stefan

> In case the package list should be grabbed or the system should be
> upgraded, pakfire got called which writes a lock file to prevent from
> beeing launched multiple times and to lock the pakfire.cgi with the
> nice
> log output.
> 
> In case update or upgrade has been performed via WUI, pakfire has
> been called
> and written the file in the background but the WUI script has been
> executed further and because of a race condition it did not recognize
> the lockfile at this moment because it was not present.
> 
> So a simple sleep should to the trick and give pakfire the required
> time
> to write out it's lockfile.
> 
> Fixes #12696.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  html/cgi-bin/pakfire.cgi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/html/cgi-bin/pakfire.cgi b/html/cgi-bin/pakfire.cgi
> index 0cf522ba1..aaf63d469 100644
> --- a/html/cgi-bin/pakfire.cgi
> +++ b/html/cgi-bin/pakfire.cgi
> @@ -133,8 +133,10 @@ END
>  
>  } elsif (($cgiparams{'ACTION'} eq 'update') && (! -e
> $Pakfire::lockfile)) {
>         &General::system_background("/usr/local/bin/pakfire",
> "update", "--force", "--no-colors");
> +       sleep(1);
>  } elsif (($cgiparams{'ACTION'} eq 'upgrade') && (!-e
> $Pakfire::lockfile)) {
>         &General::system_background("/usr/local/bin/pakfire",
> "upgrade", "-y", "--no-colors");
> +       sleep(1);
>  } elsif ($cgiparams{'ACTION'} eq "$Lang::tr{'save'}") {
>         $pakfiresettings{"TREE"} = $cgiparams{"TREE"};
>  



--===============1645664773990023893==--