From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] services.cgi: Remove links from addon services
Date: Tue, 12 Nov 2024 16:56:48 +0100 [thread overview]
Message-ID: <37175fa1-acba-4399-ba8f-1553e56ddafb@ipfire.org> (raw)
In-Reply-To: <20241111093721.4311-1-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Am 11.11.2024 um 10:37 schrieb Adolf Belka:
> - As discussed in Video Conf Call on Oct 7th 2024
> - This patch removes the links from the addon services, in line with the change made
> to the core services.
>
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> html/cgi-bin/services.cgi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index a3ae13c78..43babf522 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -161,9 +161,6 @@ END
> foreach $service (split(/ /, "$metadata{'Services'}")) {
> # Add addon name to displayname of service if servicename differs from addon
> my $displayname = ($pak ne $service) ? "$service ($pak)" : $service;
> - if ( -e "/srv/web/ipfire/cgi-bin/$pak.cgi" ) {
> - $displayname = ($pak ne $service) ? "$service (<a href=\'$pak.cgi\'>$pak</a>)" : "<a href=\'$pak.cgi\'>$service</a>";
> - }
>
> print "<td align='left' width='31%'>$displayname</td> ";
>
next prev parent reply other threads:[~2024-11-12 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 9:37 Adolf Belka
2024-11-12 15:56 ` Bernhard Bitsch [this message]
2024-11-18 20:07 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37175fa1-acba-4399-ba8f-1553e56ddafb@ipfire.org \
--to=bbitsch@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox