From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] services.cgi: Remove links from addon services
Date: Tue, 12 Nov 2024 16:56:48 +0100
Message-ID: <37175fa1-acba-4399-ba8f-1553e56ddafb@ipfire.org>
In-Reply-To: <20241111093721.4311-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1183877286656146766=="
List-Id: <development.lists.ipfire.org>

--===============1183877286656146766==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 11.11.2024 um 10:37 schrieb Adolf Belka:
> - As discussed in Video Conf Call on Oct 7th 2024
> - This patch removes the links from the addon services, in line with the ch=
ange made
>     to the core services.
>=20
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   html/cgi-bin/services.cgi | 3 ---
>   1 file changed, 3 deletions(-)
>=20
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index a3ae13c78..43babf522 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -161,9 +161,6 @@ END
>   			foreach $service (split(/ /, "$metadata{'Services'}")) {
>   				# Add addon name to displayname of service if servicename differs fro=
m addon
>   				my $displayname =3D ($pak ne $service) ? "$service ($pak)" : $service;
> -				if ( -e "/srv/web/ipfire/cgi-bin/$pak.cgi" ) {
> -					$displayname =3D ($pak ne $service) ? "$service (<a href=3D\'$pak.cgi=
\'>$pak</a>)" : "<a href=3D\'$pak.cgi\'>$service</a>";
> -				}
>  =20
>   				print "<td align=3D'left' width=3D'31%'>$displayname</td> ";
>  =20


--===============1183877286656146766==--