From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] ddns: Add provider Feste-IP.Net Signed-off-by: Martin Krieger --- *IPv6 support included based on API description but not tested. *Test system is connected by VDSL with pure IPv4 (No IPv6 or dual stack). *Setup can handle IPv4, IPv6 or dual stack updates Date: Tue, 18 May 2021 23:39:43 +0200 Message-ID: <37323352-007d-f1a6-5ce9-0d614c3ca9e3@ipfire.org> In-Reply-To: <569B3659-E76C-484C-8A05-98A3A41AF2A2@posteo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8603906049106704890==" List-Id: --===============8603906049106704890== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, thanks for your reply. First, please do not forget to keep the mailing list CC'ed. For transparency = reasons, we have a policy here stating to keep public conversations public (please refer to https://wiki.ipf= ire.org/devel/contact for details). Second, your patches _did_ made it into patchwork. They can be found in the "= ipfire" section - for your convenience, here is a list of all active patches submitted by you patchwork currently kno= ws about: https://patchwork.ipfire.org/project/ipfire/list/?submitter=3D93 Once having logged in, you can mark patches as being "superseded", so they wo= n't appear as being active anymore. Third, I have seen your updated patch and will comment on it separately the o= ther day. Thanks, and best regards, Peter M=C3=BCller > Hello Peter, >=20 > thanks for your reply. Sorry for confusion about the patch. I tried to full= fill the requirements, but due to my low experience on the git process it wen= t accidantely wrong. >=20 > I will improve & resubmit my patch according to your comments. >=20 > What ist the right way to mark patches as obsolete or remove them? My patch= es doesn=E2=80=98t seem to enter https://patchwork.ipfire.org. >=20 > Regards, >=20 > Martin Krieger >=20 > Von meinem iPad gesendet >=20 >> Am 17.05.2021 um 21:31 schrieb Peter M=C3=BCller : >> =EF=BB=BFHi, >> >> thank you for providing this. >> >> I regret to inform you that >> >> (a) both this patch and it's precursor violate the syntax of patches appli= cable to git, >> having parts of the description and various tags mangled into the RFC 5= 322 / MIME >> "Subject" header. >> >> You do not need to use "git send-email" as such (personally, I do not u= se it either, >> because my development environment cannot establish SMTP connections du= e to firewall >> policies). However, IPFire's development heavily relies on Git, so plea= se figure out >> how to run the most basic commands such as "git commit" and "git format= -patch" in >> order to properly submit your patches. >> >> (b) these patches each success each other, however missing appropriate ver= sion tags >> (such as [PATCH v2], [PATCH v3], etc.) in the RFC 5322 "Subject" header= of their >> mails. >> >> Since you did not mark the obsoleted patches as being superseded in htt= ps://patchwork.ipfire.org/, >> either, this makes it hard to keep track of the latest version of your = patch. Eventually, >> we might apply, commend or reject based on the wrong one, because of si= mply having >> overlooked there is a new, fixed version of it available. >> >> Apart from that, it would be good to see this patch tested with IPv6 and d= ual-stack scenarios >> as well - please see also my remark(s) on this below. If I understood the = documentation of >> that DDNS provider correctly, you do not really need to supply two IP addr= esses having distinct >> families. Could you at least try executing this snippet with two different= IPv4 addresses? >> >>> --- >>> README | 1 + >>> src/ddns/providers.py | 27 +++++++++++++++++++++++++++ >>> 2 files changed, 28 insertions(+) >>> >>> diff --git a/README b/README >>> index b6decb35c338..fa6ce5e598b8 100644 >>> --- a/README >>> +++ b/README >>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >>> easydns.com >>> enom.com >>> entrydns.net >>> + feste-ip.net >>> freedns.afraid.org >>> inwx.com|de|at|ch|es >>> itsdns.de >>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>> index 56e6620c78ab..009e2c9e337d 100644 >>> --- a/src/ddns/providers.py >>> +++ b/src/ddns/providers.py >>> @@ -1179,6 +1179,33 @@ class DDNSProviderEntryDNS(DDNSProvider): >>> raise DDNSUpdateError >>> >>> >>> +class DDNSProviderFesteIPNet(DDNSProtocolDynDNS2, DDNSProvider): >>> + handle =3D "feste-ip.net" >>> + name =3D "Feste-IP.Net" >>> + website =3D "https://www.feste-ip.net/" >>> + >>> + # Information about the format of the request is to be found >>> + # https://forum.feste-ip.net/viewtopic.php?f=3D13&t=3D469 >>> + >>> + myips =3D ("myip","myip2") >> >> Personal comment: Kinda ugly, but given the documentation of that provider= , there is no >> other choice to do this here... >> >>> + >>> + url =3D "https://members.feste-ip.net/nic/update/" >>> + >>> + def update(self): >>> + data =3D { >>> + "hostname" : self.hostname >>> + } >>> + >>> + for proto in DDNSProvider.protocols: >>> + idx =3D 0 >>> + tmpip =3D self.get_address(proto) >>> + if tmpip: >>> + data[self.myips[idx]] =3D tmpip >>> + idx +=3D 1 >>> + >>> + self.send_request(data) >> >> What is happening here if $tmpip equals a Boolean False? >> >>> + >>> + >>> class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>> handle =3D "freedns.afraid.org" >>> name =3D "freedns.afraid.org" >> >> Thanks, and best regards, >> Peter M=C3=BCller >=20 --===============8603906049106704890==--