From: ummeegge <ummeegge@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Added language support for chpasswd.cgi
Date: Fri, 06 Oct 2017 16:13:43 +0200 [thread overview]
Message-ID: <3764AF53-6EA9-4C97-8CFC-3975BAED984D@ipfire.org> (raw)
In-Reply-To: <1507132266.433.15.camel@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
Hi Michael,
sorry for the two patches, the 'general::swroot' part has been missing by accident :-| . Hope this is OK now.
Greetings,
UE
Am 04.10.2017 um 17:51 schrieb Michael Tremer:
> Hi,
>
> good patch.
>
> You could have dropped the $swroot variable and use $General::swroot like you
> did with many other variables.
>
> Would you send an updated patch?
>
> -Michael
next prev parent reply other threads:[~2017-10-06 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 13:03 Erik Kapfer
2017-10-04 15:51 ` Michael Tremer
2017-10-06 14:13 ` ummeegge [this message]
2017-10-06 8:28 ` [PATCH] Deleted unneeded path to $swroot Erik Kapfer
2017-10-06 14:07 ` [PATCH] chpasswd: Use well known 'General::swroot' instead of 'swroot' Erik Kapfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3764AF53-6EA9-4C97-8CFC-3975BAED984D@ipfire.org \
--to=ummeegge@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox