From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] stripper: Strip any PIE executables Date: Wed, 06 Jul 2022 12:34:51 +0000 Message-ID: <378bbff2-58fa-9c40-6c9a-c3fdda27dedf@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7147393870091744434==" List-Id: --===============7147393870091744434== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, > Did I not submit an update to that somewhere anyways? yes, you did: https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommit;h=3Dbf7bf= c3df6a3fc4e55908a9b80bcf06e51e3b46b This fell through the cracks when compiling the changelog for C169 - thanks for bringing this up. As for C170, bumping the package version is required nevertheless. All the best, Peter M=C3=BCller >=20 >> On 6 Jul 2022, at 11:00, Peter M=C3=BCller wr= ote: >> >> Hello Michael, >> >> thanks for your swift response. >> >> Okay, I will then just bump the version number of dnsdist. >> >> All the best, >> Peter M=C3=BCller >> >> >>> Good question. I did not even think about this. >>> >>> I could not find many executables that fell into this category. Maybe abo= ut 10. Out of those, dnsdist was the largest one - by far. >>> >>> So I would say, it isn=E2=80=99t worth it except for dnsdist. >>> >>> -Michael >>> >>>> On 6 Jul 2022, at 10:56, Peter M=C3=BCller = wrote: >>>> >>>> Hello Michael, >>>> >>>> just a short follow-up question on this: Do we need to re-ship all affec= ted packages again? >>>> Or is it fine to let users benefit from stripped PIE executables when we= update affected >>>> components anyway? >>>> >>>> Thanks, and best regards, >>>> Peter M=C3=BCller >>>> >>>> >>>>> Reviewed-by: Peter M=C3=BCller >>>>> >>>>>> Fixes: #12894 >>>>>> Signed-off-by: Michael Tremer >>>>>> --- >>>>>> src/stripper | 4 ++++ >>>>>> 1 file changed, 4 insertions(+) >>>>>> >>>>>> diff --git a/src/stripper b/src/stripper >>>>>> index fadbc514b..4014f03a4 100755 >>>>>> --- a/src/stripper >>>>>> +++ b/src/stripper >>>>>> @@ -38,6 +38,10 @@ function _strip() { >>>>>> args+=3D( "--strip-all" ) >>>>>> ;; >>>>>> + *Type:*"DYN (Position-Independent Executable file)"*) >>>>>> + args+=3D( "--strip-all" ) >>>>>> + ;; >>>>>> + >>>>>> # Binaries >>>>>> *Type:*"EXEC (Executable file)"*) >>>>>> args+=3D( "--strip-all" ) >>> >=20 --===============7147393870091744434==--