Re: Aw: Re: Patch for bugzilla #12050, try #2

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]

Hi,

Suggestion:

...
 Fix for Bug #12050: Adding fixed leases with one 'add' click

    Signed-off-by: BeBiMa <bbitsch(a)ipfire.org>
    Reviewed-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
...

Take your pick. ;-))

Best,
Matthias

On 16.04.2019 18:24, Matthias Fischer wrote:
> Hi,
> 
> @Bernhard:
> Right now I've got a Core 130 branch up and running - I could do this
> patch for you... Would it be ok if i do?
> 
> Best,
> Matthias
> 
> On 15.04.2019 20:49, Bernhard Bitsch wrote:
>> Hi Michael,
>> 
>> I know the "normal way" to send patches.
>> But I do not have a up-to-date git repo at the moment, reasons exist but aren't of interest for this special case.
>> I have posted the entire modified dhcpi.cgi in the forum for usage. Wanted just to supply the DevList and Bugzilla with a short and fast solution, hoping not to be to late for the announced emergency update.
>> 
>> If you want, I can post the entire modified dhcp.cgi to the DevList and someone of the devs can merge it to the git repository.
>> 
>> - Bernhard
>> 
>> BTW: I'll setup my local repo again. Further patches for this and other problems and/or developments will obey the guidance from wiki.
>> 
>>> Gesendet: Montag, 15. April 2019 um 13:12 Uhr
>>> Von: "Michael Tremer" <michael.tremer(a)ipfire.org>
>>> An: "Bernhard Bitsch" <Bernhard.Bitsch(a)gmx.de>
>>> Cc: "IPFire Development" <development(a)lists.ipfire.org>
>>> Betreff: Re: Patch for bugzilla #12050, try #2
>>>
>>> Hi Bernhard,
>>>
>>> I am happy that you are taking a look at this bug, but this is not how the process works.
>>>
>>> We have a guide on how to submit patches to the mailing list:
>>>
>>>   https://wiki.ipfire.org/devel/submit-patches
>>>
>>> There are a thousand reasons why we are doing this as we are doing it. Please follow it.
>>>
>>> -Michael
>>>
>>> > On 14 Apr 2019, at 00:04, Bernhard Bitsch <Bernhard.Bitsch(a)gmx.de> wrote:
>>> >
>>> > Please find appended the solution.
>>> >
>>> > Short description of the problem:
>>> >
>>> > After adding a new lease, you are in editing mode.
>>> > All fields are set right, but a second click ('update' ) is necessary.
>>> > With determining the exact mode 'add/edit' this second click can be avoided for new entries ( new MAC/IP combination).
>>> >
>>> > The patch adds determination of add/edit mode. If the MAC/IP pair exists in the list of fixed leases edit mode is selected, add mode is selected else.
>>> >
>>> > Sorry, did not produce the patch from git but by diffing changed file and the core 129 original.
>>> >
>>> > -Bernhard
>>> >
>>> > EDIT: produced an error by blind copy & paste, should correct with this patch.<dhcp.cgi.patch>
>>>
>>>
>> 
> 
>