From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] core 130: Remove snort settings dir after convert has run. Date: Mon, 18 Mar 2019 18:47:00 +0000 Message-ID: <3839DBB5-5396-454D-BC86-A2391225899F@ipfire.org> In-Reply-To: <20190318184625.3095-1-stefan.schantl@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0809546090409659638==" List-Id: --===============0809546090409659638== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, What happens when the converter has failed? Is that a possibility? -Michael > On 18 Mar 2019, at 18:46, Stefan Schantl wrot= e: >=20 > When all settings have been converted, the files and directory are not > needed anymore. >=20 > If they will be left and at a later time an backup will be restored, the > converter will be started by the backup script again and would be restore t= hose > old snort settings and replace the current IPS settings. >=20 > Signed-off-by: Stefan Schantl > --- > config/rootfiles/core/130/update.sh | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/config/rootfiles/core/130/update.sh b/config/rootfiles/core/13= 0/update.sh > index d33321c32..f3dc0d85a 100644 > --- a/config/rootfiles/core/130/update.sh > +++ b/config/rootfiles/core/130/update.sh > @@ -74,6 +74,9 @@ ldconfig > # Migrate snort configuration to suricata > /usr/sbin/convert-snort >=20 > +# Remove snort settings > +rm -rvf /var/ipfire/snort > + > # Start services > /etc/init.d/collectd restart > /etc/init.d/firewall restart > --=20 > 2.20.1 >=20 --===============0809546090409659638==--