From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] extrahd.cgi: Fix for Bug #12863
Date: Mon, 05 Jun 2023 11:42:13 +0100
Message-ID: <384E5994-6B69-4D61-BBC2-D425ED2559AE@ipfire.org>
In-Reply-To: <20230602190116.1790314-1-jon.murphy@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1172258239757654298=="
List-Id: <development.lists.ipfire.org>

--===============1172258239757654298==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

The syntax pains me, but this is probably correct :)

> On 2 Jun 2023, at 20:01, Jon Murphy <jon.murphy(a)ipfire.org> wrote:
>=20
> -Fixes remove entries in 'extrahd' via the webinterface for extrahd.cgi fil=
e.
>=20
> Suggested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org>
> ---
> html/cgi-bin/extrahd.cgi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index 36c0efc2e..9dd3a0eee 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -103,7 +103,7 @@ END
> }
> elsif ($extrahdsettings{'ACTION'} eq $Lang::tr{'delete'})
> {
> - if ( &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahdse=
ttings{'PATH'}")) {
> + if ( ! &General::system("/usr/local/bin/extrahdctrl", "umount", "$extrahd=
settings{'PATH'}")) {
> open( FILE, "< $devicefile" ) or die "Unable to read $devicefile";
> @tmp =3D <FILE>;
> close FILE;
> --=20
> 2.30.2
>=20


--===============1172258239757654298==--