From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] services.cgi: translate "Addon"
Date: Tue, 08 Nov 2022 17:26:09 +0000
Message-ID: <389E9E12-1642-414F-B32A-172327ECEDEE@ipfire.org>
In-Reply-To: <20221108161335.19780-1-robin.roevens@disroot.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4430308171482225684=="
List-Id: <development.lists.ipfire.org>

--===============4430308171482225684==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Robin,

> On 8 Nov 2022, at 16:13, Robin Roevens <robin.roevens(a)disroot.org> wrote:
>=20
> Signed-off-by: Robin Roevens <robin.roevens(a)disroot.org>
> ---
> html/cgi-bin/services.cgi | 4 ++--
> langs/de/cgi-bin/de.pl    | 2 +-
> langs/en/cgi-bin/en.pl    | 1 +
> langs/nl/cgi-bin/nl.pl    | 3 ++-
> 4 files changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/html/cgi-bin/services.cgi b/html/cgi-bin/services.cgi
> index 14ed01c50..3c0f27f99 100644
> --- a/html/cgi-bin/services.cgi
> +++ b/html/cgi-bin/services.cgi
> @@ -138,7 +138,7 @@ END
> print "</table></div>\n";
> &Header::closebox();
>=20
> - &Header::openbox('100%', 'left', "Addon - $Lang::tr{services}");
> + &Header::openbox('100%', 'left', "$Lang::tr{addon} - $Lang::tr{services}"=
);
> my $paramstr=3D$ENV{QUERY_STRING};
> my @param=3Dsplit(/!/, $paramstr);
> # Make sure action parameter is actually one of the allowed service actions
> @@ -156,7 +156,7 @@ END
> <div align=3D'center'>
> <table width=3D'80%' cellspacing=3D'1' class=3D'tbl'>
> <tr>
> - <th align=3D'left'><b>Addon $Lang::tr{service}</b></th>
> + <th align=3D'left'><b>$Lang::tr{addon} $Lang::tr{service}</b></th>
> <th align=3D'center'><b>Boot</b></th>
> <th align=3D'center' colspan=3D2><b>$Lang::tr{'action'}</b></th>
> <th align=3D'center'><b>$Lang::tr{'status'}</b></th>
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index db7d117b0..8310f7eba 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -157,7 +157,7 @@
> 'add xtaccess' =3D> 'Externen Zugang hinzugef=C3=BCgt',
> 'add-route' =3D> 'Zus=C3=A4tzlich zu propagierende Route',
> 'added from dhcp lease list' =3D> 'hinzugef=C3=BCgt von der DHCP-Zuordnungs=
liste',
> -'addon' =3D> 'Add-Ons',
> +'addon' =3D> 'Add-On',
> 'addons' =3D> 'Add-Ons',
> 'admin user password has been changed' =3D> 'Passwort f=C3=BCr Benutzer adm=
in wurde ge=C3=A4ndert.',
> 'admin users' =3D> 'Liste der Benutzer mit Super User Rechten',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 60dca5be4..2aec959c3 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -155,6 +155,7 @@
> 'add xtaccess' =3D> 'Add External Access',
> 'add-route' =3D> 'Additional push route',
> 'added from dhcp lease list' =3D> 'Added from DHCP lease list',
> +'addon' =3D> 'Addon',
> 'addons' =3D> 'Addons',

Shouldn=E2=80=99t we be consistent and call them =E2=80=9CAdd-on=E2=80=9D eve=
rywhere?

Technically this patch is not introducing that as an error, because it has be=
en =E2=80=9CAddon=E2=80=9D before, but I suppose we should be consistent.

-Michael

> 'admin user password has been changed' =3D> 'Admin user password has been c=
hanged.',
> 'admin users' =3D> 'User with superuser rights',
> diff --git a/langs/nl/cgi-bin/nl.pl b/langs/nl/cgi-bin/nl.pl
> index 4fd6955cc..cd790e595 100644
> --- a/langs/nl/cgi-bin/nl.pl
> +++ b/langs/nl/cgi-bin/nl.pl
> @@ -95,7 +95,8 @@
> 'add xtaccess' =3D> 'Voeg een externe toegang toe',
> 'add-route' =3D> 'Extra push route',
> 'added from dhcp lease list' =3D> 'Toegevoegd van DHCP lease-lijst.',
> -'addons' =3D> 'Toevoegingen',
> +'addon' =3D> 'Add-on',
> +'addons' =3D> 'Add-ons',
> 'admin user password has been changed' =3D> 'Beheerderswachtwoord is gewijz=
igd.',
> 'admin users' =3D> 'Gebruiker met beheerdersrechten.',
> 'administrator user password' =3D> 'Beheerderswachtwoord:',
> --=20
> 2.38.0
>=20
>=20
> --=20
> Dit bericht is gescanned op virussen en andere gevaarlijke
> inhoud door MailScanner en lijkt schoon te zijn.
>=20


--===============4430308171482225684==--