Re: [PATCH] Syntax fixes in several CGIs

[Leo Hofmann <hofmann@leo-andres.de>]

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

Hi Matthias,

if you want to use longer texts as button names, I would like to suggest that you use the HTML "button" element.
This element accepts a seperate description text and form value attribute. I think this would be the best option,
because then the CGI "ACTION" parameter becomes independent of the translation strings.

Here you will find an example:
https://www.w3schools.com/tags/att_button_name.asp

Best regards,
Leo

Am 29.12.2020 um 17:51 schrieb Matthias Fischer:
> On 29.12.2020 14:50, Bernhard Bitsch wrote:
>> Hi,
>>
>> to avoid possible mis-interpretation by Perl we do not need to set the hash tags in '.
>> For example
>>    value='$Lang::tr{'update'}'
>> can read
>>    value='$Lang::tr{update}'
>>
>> In most locations we use the stringifying, it is just cosmetic. Thus an overall editing is not needed.
> Ok, thanks.
>
> I thought it was mandatory because of Michaels comment about the 'Save'
> translation in 'wlanap.cgi'. And in fact I once ran into problems using
> something like value=$Lang::tr{'Save and restart'}. This didn't work as
> expected. As Michael wrote, this was "longer than one word in one
> language". ;-) It just refused to be translated as a whole.
>
> But at the risk of sounding silly: I still got translation and
> designation(?) problems, sorry.
>
> Hash tag = '$Lang::tr{'update'}'!?
>
> Stringifying = ???
>
>> Greets,
>> Bernhard
>>
>>> Gesendet: Dienstag, 29. Dezember 2020 um 13:50 Uhr
>>> Von: "Matthias Fischer" <matthias.fischer(a)ipfire.org>
>>> An: development(a)lists.ipfire.org
>>> Betreff: [PATCH] Syntax fixes in several CGIs
>>>
>>> Signed-off-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
>>> ---
>>>   html/cgi-bin/asterisk/calls.cgi | 2 +-
>>>   html/cgi-bin/asterisk/conf.cgi  | 2 +-
>>>   html/cgi-bin/extrahd.cgi        | 4 ++--
>>>   html/cgi-bin/gpl.cgi            | 2 +-
>>>   html/cgi-bin/hardwaregraphs.cgi | 2 +-
>>>   html/cgi-bin/optionsfw.cgi      | 4 ++--
>>>   html/cgi-bin/upnp.cgi           | 2 +-
>>>   7 files changed, 9 insertions(+), 9 deletions(-)
>>> [Shortened...]