public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] Revived as addon: squid graphs 3.2
Date: Tue, 14 Nov 2017 12:48:01 +0100	[thread overview]
Message-ID: <398977a8-17ca-a09a-c27d-df7840b14a70@ipfire.org> (raw)
In-Reply-To: <1510613765.3441.13.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Hi,

On 13.11.2017 23:56, Michael Tremer wrote:
> Hi,
> 
> On Sun, 2017-11-12 at 11:11 +0100, Matthias Fischer wrote:
>> Hi,
>> 
>> On 12.11.2017 01:34, Matthias Fischer wrote:
>> > Hi,
>> > 
>> > For details see:
>> > https://sourceforge.net/projects/squid-graph/
>> > ...
>> After looking at this, I thought it would be better and easier to
>> maintain this addon if I build and pack it like 'squid-accounting' or
>> 'wio' (e.g.).
> 
> Well, since there is an upstream project, I think it is probably best
> to use their tarball and have patches against the latest release.

Somehow I knew you would write that... ;-)
I thought about that, too.

> However, this is indeed quite old, so it might make sense to fork it
> and have an own git repository to work on it and release every once in
> a while. Like we do with guardian...
> 
> Maybe it makes sense to get in touch with the original maintainer and
> see where that goes. That depends on what changes you are going to
> make.

Hm. I have the feeling that this could be a timeconsuming procedure with
some up and downs and I would want to get this thing done somehow. So
prior to search for a - in the meantime no longer existent? - original
maintainer, I'd prefer to use the upstream package like in acient days
(IPCop) and apply a patch. I don't change anything in the original
working code, I just do some 'polishing'.

IPCop did it that way with some 'sed'-lines. There is only one file to
patch, everything else are added scripts from us for integration in
IPFire (controlling, polishing and localisation) and for Pakfire.

As a result we would have ONE file to download and a few files to
maintain which could be easily done through GIT.

What do you think?

Best,
Matthias

  reply	other threads:[~2017-11-14 11:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-12  0:34 Matthias Fischer
2017-11-12 10:11 ` Matthias Fischer
2017-11-13 22:56   ` Michael Tremer
2017-11-14 11:48     ` Matthias Fischer [this message]
2017-11-15 13:17     ` Matthias Fischer
  -- strict thread matches above, loose matches on Subject: below --
2017-11-12 20:59 [PATCH] Revived (as addon): " Matthias Fischer
2017-11-11 21:45 Matthias Fischer
2017-11-11 22:38 ` Matthias Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=398977a8-17ca-a09a-c27d-df7840b14a70@ipfire.org \
    --to=matthias.fischer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox