From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: How to test a solution for bug 12539 Date: Fri, 27 Nov 2020 16:55:44 +0000 Message-ID: <3990D1D7-44E1-492A-A5BB-3914FCC07371@ipfire.org> In-Reply-To: <75630cdc-fb4d-b4a3-9e7c-1ffb0c71675f@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6387833652431835502==" List-Id: --===============6387833652431835502== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hey Adolf, I think the fundamental problem here is that we are running a shell command t= o edit a string. https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dhtml/cgi-bin/services= .cgi;h=3D26ab4f3143fff36434287ec085aaa47993726ff1;hb=3DHEAD#l164 Furthermore that shell command is returning what is the second element betwee= n hyphens. This is not what we want. We actually simply want whatever comes a= fter =E2=80=9Cmeta-=E2=80=9C. My suggestion is to change the call of =E2=80=9Cfind=E2=80=9D (line 164) so t= hat we use Perl-native code to list all files in that directory. We then cut off the first five characters if they are =E2=80=9Cmeta-=E2=80=9C= . Otherwise we ignore the file. We then have the correct name of the service we are looking for. We should also change the second call to =E2=80=9Cfind=E2=80=9D (line 169) wh= ich simply could be: if (-e =E2=80=9C/etc/init.d/${service}=E2=80=9D) { =E2=80=A6 } That way, the code would be more secure because any shell command injections = are impossible. It would perform a lot quicker because it takes a very very l= ong time to launch a shell command. And last but not least it does what we in= tend. Is this what you were looking for? -Michael > On 26 Nov 2020, at 22:22, Adolf Belka wrote: >=20 > Dear All, >=20 > I have been working on a solution for bug 12539. >=20 > With cups and cups-filters installed the services tab shows cups twice in t= he add-on list. This is because the cut command from the installed meta files= causes both meta-cups and meta-cups-filters to result in cups and therefore = shows up twice. >=20 > The solution seems to be to rename the Prog name from cups-filters to cups_= filters. I made these changes in my local repo and everything built successfu= lly. >=20 > However I can not figure out how to test and confirm that it has worked. >=20 > If I install the built ISO and then install cups and cups_filters from pakf= ire they load the programs from the IPFire repo and therefore load the origin= al versions which still have the problem and show up twice in the services ta= b. >=20 > If I copy the cup and cups_filters ipfire packages and install them into my= test bed system, the programs are installed and can be successfully started = but because they were not installed by pakfire they have not been added to th= e installed meta files in /opt/pakfire/db/installed/meta-* and therefore do n= ot show up in the services tab at all. >=20 > Can anyone help me with advice on how to be able to install these modified = add-on packages so I can check that the original problem is actually solved b= y my solution, or do I have to just submit a patch and the review of the patc= h will tell me if I have done it correctly or not. >=20 > Thanks for any help/advice, >=20 > Adolf >=20 --===============6387833652431835502==--