public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: glitch in patchwork?
Date: Thu, 24 Nov 2022 11:32:47 +0000	[thread overview]
Message-ID: <39B30904-6037-410C-87CA-ECF93772C8B5@ipfire.org> (raw)
In-Reply-To: <790d1abd-a493-6265-4b22-ace8c8f6a734@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Hello Paul,

This does happen sometimes, indeed.

Mostly it happens with any patches that contain non-ascii characters.

Patchwork calculates a hash over a patch and stores that hash in its database. We then calculate hashes for all commits and use those to find any patches in the database. When there are any funny characters in it, it does not seem to work.

I would consider this a bug in Patchwork, but did not have the time to investigate, yet.

So, those patches need to be manually marked as Staged or Merged.

-Michael

> On 24 Nov 2022, at 00:42, Paul Simmons <mbatranch(a)gmail.com> wrote:
> 
> Hey, All.
> 
> I've noticed occasional discrepancies in PATCHWORK.
> 
> For example, https://patchwork.ipfire.org/project/ipfire/patch/20221108200911.11156-1-robin.roevens(a)disroot.org/ status displays as "New", but was committed as https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=e47370a167869da39c5962ff9f9f032d7bd995ee
> 
> This isn't a show stopper, but I thought I should point it out.
> 
> Thanks, and happy coding,
> Paul
> 
> -- 
> As I’ve gotten older, people think I’ve become lazy.  The truth is I’m just being more energy efficient.
> 


  reply	other threads:[~2022-11-24 11:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24  0:42 Paul Simmons
2022-11-24 11:32 ` Michael Tremer [this message]
2022-11-24 16:56   ` Paul Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39B30904-6037-410C-87CA-ECF93772C8B5@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox