From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: backup.pl - gzip not working as expected!?
Date: Mon, 27 Dec 2021 11:38:11 +0100
Message-ID: <3D2CF659-5EEE-46CA-A6E3-99AECDD681AB@ipfire.org>
In-Reply-To: <b21362c2-ad3b-97e7-f383-722a1049871a@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0166712526232791968=="
List-Id: <development.lists.ipfire.org>

--===============0166712526232791968==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Thank you for double-checking.

-Michael

> On 27 Dec 2021, at 10:32, Matthias Fischer <matthias.fischer(a)ipfire.org> =
wrote:
>=20
> Hi,
>=20
> On 26.12.2021 21:48, Michael Tremer wrote:
>> Hello,
>>=20
>>> On 25 Dec 2021, at 20:53, Matthias Fischer <matthias.fischer(a)ipfire.org=
> wrote:
>>>=20
>>> Hi,
>>>=20
>>> I wondered for some time - since Friday 21.5.2021 ( ;-) ) - that the IPF
>>> files of the ISO backups turned out much larger than before.
>>=20
>> Yes, they were indeed not compressed at all:
>>=20
>> https://bugzilla.ipfire.org/show_bug.cgi?id=3D12737
>=20
> Seems I was really busy in the last weeks, otherwise I would have seen
> that this problem was already reported. D'oh!
>=20
>> So this should be resolved in c163. Can you test and confirm?
>=20
> I first applied the changes from "[2/3] backup: Create tarball in one
> pass" and can confirm.
>=20
> The IPF file of the *ISO backup* is now identical to the one created
> *without logs* and correctly compressed as reported by Larsen in
> https://bugzilla.ipfire.org/show_bug.cgi?id=3D12737#c2 (see attachment).
>=20
> In a second run I also applied "[1/3] backup: Use filename as specified
> on console" and "[3/3] backup: Fork ISO job into the background in CGI
> script" from https://patchwork.ipfire.org/project/ipfire/list/?series=3D2450
>=20
> Looking good.
>=20
> Best,
> Matthias
>=20
>> -Michael
>>=20
>>> Today I tested: when I make a backup *without* logs, the resulting IPF
>>> is about *26MB* in size.
>>>=20
>>> The same file is about *108MB* in size when I make an *ISO backup*.
>>>=20
>>> So I ran ' /var/ipfire/backup/bin/backup.pl iso' from console and
>>> watched the output.
>>>=20
>>> After some time, 'gzip' told me:
>>>=20
>>> ...
>>> gzip: /var/ipfire/backup/2021-12-25-20:34.ipf already has .ipf suffix --
>>> unchanged
>>> ...
>>>=20
>>> For results, please see attached screenshot (and yes: I use tables... ;-)=
 ).
>>>=20
>>> The first IPF was created using 'Generate ISO', the second using
>>> 'Exclude logfiles'.
>>>=20
>>> Can anyone confirm?
>>>=20
>>> Best,
>>> Matthias<ipf_files_differ_in_size.png>
>>=20
> <01_ipf_iso_and_without_logs.png><02_ipf_iso_and_without_logs.png>


--===============0166712526232791968==--