From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: libnfnetlink and libmnl Date: Wed, 06 Apr 2022 15:42:03 +0100 Message-ID: <3DFC81E6-7A67-4881-BC3A-A649166AAA84@ipfire.org> In-Reply-To: <4e6c185f-5ebd-6235-2c7b-3036bbec41c5@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8429492130727627559==" List-Id: --===============8429492130727627559== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Adolf, > On 6 Apr 2022, at 14:18, Adolf Belka wrote: >=20 > Hi All, >=20 > We have both libnfnetlink and libmnl in IPFire. I have just done an update = of libmnl. > There is an update of libnfnetlink but it also says that libnfnetlink is st= ill deprecated and should preferably be replaced by libmnl Oh this is very interesting. It looks like libmnl was introduced for conntrack-tools in this commit: commit a10733a5d8580b6ab8cff46235daab6547723781 Author: Arne Fitzenreiter Date: Thu Jan 3 14:27:11 2013 +0100 conntrack-tools: add conntrack and needed deps. You can try to comment out libnfnetlink and libmnl and run a clean build and = see if it goes through. If so, then we can safely drop them. > I have run ./make.sh find-dependencies on both libmnl.so.0.2.0 and libnfnet= link.so.0.2.0 and neither came up with anything. Doing a grep on the git repo= sitory for mnl or nfnetlink also didn't indicate anything using these. > How are they being used and what needs to be done to change the usage of li= bnfnetlink to libmnl? See above. I believe there are a couple of other candidates for this which we should hav= e a look at. There is libdnet that I noticed a little while ago, but I am sur= e there will be plenty more when looking through the package list: libaio libart libnet libnl (and if something depends on it, can it not use libnl-3?) libpri (if I remember correctly this was a dependency of asterisk) libsolv can absolutely go for the moment, we don=E2=80=99t need it netpbm? pigz (we don=E2=80=99t use it anywhere since we are compressing images with X= Z b302b9a695e391477eab0cb2343f3ba1b1ba1989) sdparm If you have the time, maybe you can have a look at what is used somewhere and= what can be dropped? This won=E2=80=99t shrink the distribution by a massive amount, but why shoul= d we carry around dead code? Best, -Michael > Regards, > Adolf --===============8429492130727627559==--