From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [RFC PATCH] backup: Set owner of /var/ipfire/backup/{in, ex}clude
 to "root"
Date: Fri, 16 Sep 2022 10:27:19 +0200
Message-ID: <3E4A3080-E33E-4EB9-B431-746D8D3C78FA@ipfire.org>
In-Reply-To: <d0225ffd-d82d-ede0-87f1-9ca4fb879dd8@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0596481360800717680=="
List-Id: <development.lists.ipfire.org>

--===============0596481360800717680==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Peter,

I agree that the files should be owned by root. However, your patch doesn=E2=
=80=99t fix that.

> On 15 Sep 2022, at 21:15, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> Since these files are static, there is no legitimate reason why they
> should be owned (hence writable) by "nobody".
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> lfs/backup | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/lfs/backup b/lfs/backup
> index 6f686bf22..adbf16e65 100644
> --- a/lfs/backup
> +++ b/lfs/backup
> @@ -1,7 +1,7 @@
> ###########################################################################=
####
> #                                                                          =
   #
> # IPFire.org - A linux based firewall                                      =
   #
> -# Copyright (C) 2007-2021  IPFire Team  <info(a)ipfire.org>               =
      #
> +# Copyright (C) 2007-2022  IPFire Team  <info(a)ipfire.org>               =
      #
> #                                                                          =
   #
> # This program is free software: you can redistribute it and/or modify     =
   #
> # it under the terms of the GNU General Public License as published by     =
   #
> @@ -61,8 +61,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> 	@$(PREBUILD)
> 	-mkdir -p /var/ipfire/backup/bin
> 	install -v -m 755 -o root $(DIR_SRC)/config/backup/backup.pl /var/ipfire/b=
ackup/bin
> -	install -v -m 644 $(DIR_SRC)/config/backup/include /var/ipfire/backup/
> -	install -v -m 644 $(DIR_SRC)/config/backup/exclude /var/ipfire/backup/
> +	install -v -m 644 -o root $(DIR_SRC)/config/backup/include /var/ipfire/ba=
ckup/
> +	install -v -m 644 -o root $(DIR_SRC)/config/backup/exclude /var/ipfire/ba=
ckup/

They have been created as root before. That is the default.

> 	chown nobody:nobody -R /var/ipfire/backup/

And here is where they will be changed. Still.

> 	chown root:root -R /var/ipfire/backup/bin/
> 	-mkdir -p /var/ipfire/backup/addons
> --=20
> 2.35.3

-Michael

--===============0596481360800717680==--