Re: [PATCH] ncdu-1.15.1

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 6514 bytes --]

Hello,

cool. That is good to know. You should include those things in your commit message.

I wrote a blog post a couple of years ago now which outlines a little bit what is helpful to others:

  https://blog.ipfire.org/post/how-to-write-a-good-commit-message

There is more detailed information here:

  https://wiki.ipfire.org/devel/git/commit-messages

And this is well a reminder for everybody else :)

Best,
-Michael

> On 24 Aug 2020, at 16:21, smooky <smooky(a)v16.de> wrote:
> 
> Hi Michael.
> 
> I use this tool to quickly and easily find the largest memory consumers on my hard drives. I have e.g. Samba run as a file server where there are always many files quickly. With this tool it is possible for me to find the biggest memory hogs very quickly. It can search directly in the whole system or in individual folders. It is also very pleasant that the tool shows everything in a tree hierarchy, which speeds up the search enormously.
> 
> best regards
> 
> Marcel
> 
> 
> -------- Ursprüngliche Nachricht --------
> Von: Michael Tremer <michael.tremer(a)ipfire.org>
> Datum: 24.08.20 16:38 (GMT+01:00)
> An: smooky(a)v16.de
> Cc: "IPFire: Development-List" <development(a)lists.ipfire.org>, Marcel Follert <smooky(a)16.de>
> Betreff: Re: [PATCH] ncdu-1.15.1
> 
> Hello Marcel,
> 
> Thank you for your patch.
> 
> Before we talk about the actual patch I would like to know the use case for this package in IPFire.
> 
> Best,
> -Michael
> 
> > On 21 Aug 2020, at 20:37, smooky(a)v16.de wrote:
> > 
> >>>> https://dev.yorhel.nl/ncdu <<<
> > 
> > Ncdu is a disk usage analyzer with an ncurses interface. 
> > It is designed to find space hogs on a remote server where you don't 
> > have an entire graphical setup available, 
> > but it is a useful tool even on regular desktop systems. 
> > Ncdu aims to be fast, simple and easy to use, 
> > and should be able to run in any minimal POSIX-like environment 
> > with ncurses installed.
> > 
> > Signed-off-by: Marcel Follert (Smooky) <smooky(a)16.de>
> > ---
> > config/rootfiles/packages/ncdu |  2 +
> > lfs/ncdu                       | 85 ++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 87 insertions(+)
> > create mode 100644 config/rootfiles/packages/ncdu
> > create mode 100644 lfs/ncdu
> > 
> > diff --git a/config/rootfiles/packages/ncdu b/config/rootfiles/packages/ncdu
> > new file mode 100644
> > index 000000000..0dd1d7ac6
> > --- /dev/null
> > +++ b/config/rootfiles/packages/ncdu
> > @@ -0,0 +1,2 @@
> > +usr/bin/ncdu
> > +#usr/share/man/man1/ncdu.1
> > diff --git a/lfs/ncdu b/lfs/ncdu
> > new file mode 100644
> > index 000000000..0ea9370b2
> > --- /dev/null
> > +++ b/lfs/ncdu
> > @@ -0,0 +1,85 @@
> > +###############################################################################
> > +#                                                                             #
> > +# IPFire.org - A linux based firewall                                         #
> > +# Copyright (C) 2007-2020  IPFire Team  <info(a)ipfire.org>                     #
> > +#                                                                             #
> > +# This program is free software: you can redistribute it and/or modify        #
> > +# it under the terms of the GNU General Public License as published by        #
> > +# the Free Software Foundation, either version 3 of the License, or           #
> > +# (at your option) any later version.                                         #
> > +#                                                                             #
> > +# This program is distributed in the hope that it will be useful,             #
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
> > +# GNU General Public License for more details.                                #
> > +#                                                                             #
> > +# You should have received a copy of the GNU General Public License           #
> > +# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
> > +#                                                                             #
> > +###############################################################################
> > +
> > +
> > +###############################################################################
> > +# Definitions
> > +###############################################################################
> > +
> > +include Config
> > +
> > +VER        = 1.15.1
> > +
> > +THISAPP    = ncdu-$(VER)
> > +DL_FILE    = $(THISAPP).tar.gz
> > +DL_FROM    = $(URL_IPFIRE)
> > +DIR_APP    = $(DIR_SRC)/$(THISAPP)
> > +TARGET     = $(DIR_INFO)/$(THISAPP)
> > +PROG     = ncdu
> > +PAK_VER    = 1
> > +
> > +DEPS     = 
> > +
> > +###############################################################################
> > +# Top-level Rules
> > +###############################################################################
> > +
> > +objects = $(DL_FILE)
> > +
> > +$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> > +
> > +$(DL_FILE)_MD5 = af25aa8462a6f29c8a0c4d3d83d186e7
> > +
> > +install : $(TARGET)
> > +
> > +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> > +
> > +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> > +
> > +md5 : $(subst %,%_MD5,$(objects))
> > +
> > +dist: 
> > + @$(PAK)
> > +
> > +###############################################################################
> > +# Downloading, checking, md5sum
> > +###############################################################################
> > +
> > +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> > + @$(CHECK)
> > +
> > +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> > + @$(LOAD)
> > +
> > +$(subst %,%_MD5,$(objects)) :
> > + @$(MD5)
> > +
> > +###############################################################################
> > +# Installation Details
> > +###############################################################################
> > +
> > +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> > + @$(PREBUILD)
> > + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar xvf $(DIR_DL)/$(DL_FILE)
> > + cd $(DIR_APP) && ./configure --prefix=/usr
> > + cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
> > + cd $(DIR_APP) && make install
> > + @rm -rf $(DIR_APP)
> > + @$(POSTBUILD)
> > -- 
> > 2.12.2
> > 
>