From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] network-functions.pl: Improve wifi_get_link_quality
Date: Wed, 04 Aug 2021 16:36:38 +0200
Message-ID: <3F363A0D-6B08-4C8F-A296-040E1E701F6A@ipfire.org>
In-Reply-To: <20210723110942.679-1-hofmann@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0034337901551967549=="
List-Id: <development.lists.ipfire.org>

--===============0034337901551967549==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

Good catch :)

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

-Michael

> On 23 Jul 2021, at 13:09, Leo-Andres Hofmann <hofmann(a)leo-andres.de> wrot=
e:
>=20
> iwconfig doesn't return values for "Link Quality" if the interface
> is disconnected, causing a division by zero error. If there are odd
> values, the resulting percentage may contain many decimal places.
>=20
> This patch makes wifi_get_link_quality return zero instead of failing
> and rounds the percentage to a more meaningful integer.
>=20
> Signed-off-by: Leo-Andres Hofmann <hofmann(a)leo-andres.de>
> ---
> config/cfgroot/network-functions.pl | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>=20
> diff --git a/config/cfgroot/network-functions.pl b/config/cfgroot/network-f=
unctions.pl
> index b7a840559..c0abc76b5 100644
> --- a/config/cfgroot/network-functions.pl
> +++ b/config/cfgroot/network-functions.pl
> @@ -403,7 +403,11 @@ sub wifi_get_link_quality($) {
>=20
> 	my ($cur, $max) =3D $status =3D~ /Link Quality=3D(\d+)\/(\d+)/;
>=20
> -	return $cur * 100 / $max;
> +	if($max > 0) {
> +		return sprintf('%.0f', ($cur * 100) / $max);
> +	}
> +
> +	return 0;
> }
>=20
> sub wifi_get_signal_level($) {
> --=20
> 2.27.0.windows.1
>=20


--===============0034337901551967549==--