From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 8/9] Revert "gcp-setup: Fixes bug12763"
Date: Fri, 10 May 2024 17:24:27 +0200 [thread overview]
Message-ID: <3b04a6cc-585a-430e-a0b7-a5949fcf963b@ipfire.org> (raw)
In-Reply-To: <20240510120234.995049-8-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>
On 10/05/2024 14:02, Michael Tremer wrote:
> This reverts commit 2841a675482879a5eb6bfeaabb268066af762e9d.
>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> src/initscripts/helper/gcp-setup | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/initscripts/helper/gcp-setup b/src/initscripts/helper/gcp-setup
> index 8273b70b4..4f5148c3e 100644
> --- a/src/initscripts/helper/gcp-setup
> +++ b/src/initscripts/helper/gcp-setup
> @@ -268,8 +268,8 @@ case "${reason}" in
> ip addr add "${new_ip_address}/${new_subnet_mask}" dev "${interface}"
>
> # Add the default route
> - ip route add "${new_routers}" dev "${interface}" >/dev/null 2>&1
> - ip route add default via "${new_routers}" >/dev/null 2>&1
> + ip route add "${new_routers}" dev "${interface}"
> + ip route add default via "${new_routers}"
>
> # Setup DNS
> for domain_name_server in ${new_domain_name_servers}; do
next prev parent reply other threads:[~2024-05-10 15:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 12:02 [PATCH 1/9] ipsec-interfaces: Don't throw away errors when creating routes Michael Tremer
2024-05-10 12:02 ` [PATCH 2/9] Revert "static-routes: Fixes bug12763" Michael Tremer
2024-05-10 15:22 ` Adolf Belka
2024-05-10 12:02 ` [PATCH 3/9] Revert "red: " Michael Tremer
2024-05-10 15:22 ` Adolf Belka
2024-05-10 12:02 ` [PATCH 4/9] Revert "ip-up: " Michael Tremer
2024-05-10 15:23 ` Adolf Belka
2024-05-10 12:02 ` [PATCH 5/9] Revert "aws-setup: " Michael Tremer
2024-05-10 15:23 ` Adolf Belka
2024-05-10 12:02 ` [PATCH 6/9] Revert "azure-setup: " Michael Tremer
2024-05-10 15:23 ` Adolf Belka
2024-05-10 12:02 ` [PATCH 7/9] Revert "exoscale-setup: " Michael Tremer
2024-05-10 15:24 ` Adolf Belka
2024-05-10 12:02 ` [PATCH 8/9] Revert "gcp-setup: " Michael Tremer
2024-05-10 15:24 ` Adolf Belka [this message]
2024-05-10 12:02 ` [PATCH 9/9] Revert "oci-setup: " Michael Tremer
2024-05-10 15:24 ` Adolf Belka
2024-05-10 15:21 ` [PATCH 1/9] ipsec-interfaces: Don't throw away errors when creating routes Adolf Belka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b04a6cc-585a-430e-a0b7-a5949fcf963b@ipfire.org \
--to=adolf.belka@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox