Re: [PATCH] update-ipblocklists: remove "<INFO> Skipping" log entries

[Adolf Belka <adolf.belka@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 3956 bytes --]

Hi All,

On 05/06/2024 18:47, jon wrote:
> Comments below...
> 
> 
> Jon
> 
> 
>> On Jun 5, 2024, at 4:55 AM, Adolf Belka <adolf.belka(a)ipfire.org <mailto:adolf.belka(a)ipfire.org>> wrote:
>>
>> Hi All,
>>
>> On 05/06/2024 11:28, Michael Tremer wrote:
>>> Hello Jon,
>>>
>>> Why should this not be logged?
>>>
> 
> Michael - To me Line 89 `<INFO> Skipping $blocklist blocklist - Too frequent update attempts!` has little to no value since it is time based (i.e., it is not time to update).
> See: https://github.com/ipfire/ipfire-2.x/blob/master/src/scripts/update-ipblocklists#L89 <https://github.com/ipfire/ipfire-2.x/blob/master/src/scripts/update-ipblocklists#L89>
> 
> And to me the Line 103 `<INFO> Skipping $blocklist blocklist - It has not been modified!` has little value.
> See: https://github.com/ipfire/ipfire-2.x/blob/master/src/scripts/update-ipblocklists#L103 <https://github.com/ipfire/ipfire-2.x/blob/master/src/scripts/update-ipblocklists#L103>
> 
> If it is to be used for troubleshooting maybe the date of last modification be added to the log message (e.g., $last_modified):
> See: https://github.com/ipfire/ipfire-2.x/blob/master/config/cfgroot/ipblocklist-functions.pl#L167 <https://github.com/ipfire/ipfire-2.x/blob/master/config/cfgroot/ipblocklist-functions.pl#L167>

I will look at doing something like that.

Regards,
Adolf.

> 
> Otherwise I would remove.
> 
> Just my 2c,
> 
> 
>>> -Michael
>>>
>>>> On 4 Jun 2024, at 21:22, Jon Murphy <jon.murphy(a)ipfire.org <mailto:jon.murphy(a)ipfire.org>> wrote:
>>>>
>>>> - Remove two <INFO> log entries from message log.
>>>>
>>>> Signed-off-by: Jon Murphy <jon.murphy(a)ipfire.org <mailto:jon.murphy(a)ipfire.org>>
>>>> ---
>>>> src/scripts/update-ipblocklists | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/src/scripts/update-ipblocklists b/src/scripts/update-ipblocklists
>>>> index a17b47999..dddde8d27 100644
>>>> --- a/src/scripts/update-ipblocklists
>>>> +++ b/src/scripts/update-ipblocklists
>>>> @@ -86,7 +86,7 @@ foreach my $blocklist (@blocklists) {
>>>> # Check if enough time has passed since the last download of the list.
>>>> if ($time <= $holdoff_time) {
>>>> # To frequent updates, log to syslog.
>>>> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent update attempts!");
>>>> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - Too frequent update attempts!");
>>>>
>>>> # Skip this provider.
>>>> next;
>>>> @@ -100,7 +100,7 @@ foreach my $blocklist (@blocklists) {
>>>> # Handle different return codes.
>>>> if ($return eq "not_modified") {
>>>> # Log notice to syslog.
>>>> - &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been modified!");
>>>> + # &_log_to_syslog("<INFO> Skipping $blocklist blocklist - It has not been modified!");
>>>> } elsif ($return eq "dl_error") {
>>>> # Log error to the syslog.
>>>> &_log_to_syslog("<ERROR> Could not update $blocklist blocklist - Download error\!");
>> The log message about not being modified was what a forum user was able to use to identify that the Alien Vault list had not been updated for at least 17 months.
>> That information could not be found from the Alien Vault site as there is no timestamp on the file being downloaded to be able to be processed.
>>
> 
> Adolf - I did not change the `<INFO> Successfully updated ...` so a user should be able make a determination something stopped.
> 
>> I would not want to lose this information otherwise when another provider silently closes their list because they have been taken over or decide to concentrate on funded lists it will prove very hard to figure out if the lists are still active, even more so as more lists get added.
>>
> 
> See my "troubleshooting" comment above.
> 
>> Regards,
>> Adolf.
>>
>>
>>>> -- 
>>>> 2.30.2
>>>>
>>
>> -- 
>> Sent from my laptop
>>
>