From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: [PATCH] update-ipblocklists: remove " Skipping" log entries Date: Thu, 06 Jun 2024 16:55:52 +0200 Message-ID: <3b83f7cf-1d66-486c-b4fc-703247d036c6@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1145441317614519129==" List-Id: --===============1145441317614519129== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi All, On 05/06/2024 18:47, jon wrote: > Comments below... >=20 >=20 > Jon >=20 >=20 >> On Jun 5, 2024, at 4:55 AM, Adolf Belka > wrote: >> >> Hi All, >> >> On 05/06/2024 11:28, Michael Tremer wrote: >>> Hello Jon, >>> >>> Why should this not be logged? >>> >=20 > Michael - To me Line 89 ` Skipping=C2=A0$blocklist=C2=A0blocklist - T= oo frequent update attempts!` has little to no value since it is time based (= i.e., it is not time to update). > See: https://github.com/ipfire/ipfire-2.x/blob/master/src/scripts/update-ip= blocklists#L89 >=20 > And to me the Line 103 ` Skipping=C2=A0$blocklist blocklist - It has = not been modified!` has little value. > See: https://github.com/ipfire/ipfire-2.x/blob/master/src/scripts/update-ip= blocklists#L103 >=20 > If it is to be used for troubleshooting maybe the date of last modification= be added to the log message (e.g., $last_modified): > See: https://github.com/ipfire/ipfire-2.x/blob/master/config/cfgroot/ipbloc= klist-functions.pl#L167 I will look at doing something like that. Regards, Adolf. >=20 > Otherwise I would remove. >=20 > Just my 2c, >=20 >=20 >>> -Michael >>> >>>> On 4 Jun 2024, at 21:22, Jon Murphy > wrote: >>>> >>>> - Remove two log entries from message log. >>>> >>>> Signed-off-by: Jon Murphy > >>>> --- >>>> src/scripts/update-ipblocklists | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/src/scripts/update-ipblocklists b/src/scripts/update-ipbloc= klists >>>> index a17b47999..dddde8d27 100644 >>>> --- a/src/scripts/update-ipblocklists >>>> +++ b/src/scripts/update-ipblocklists >>>> @@ -86,7 +86,7 @@ foreach my $blocklist (@blocklists) { >>>> # Check if enough time has passed since the last download of the list. >>>> if ($time <=3D $holdoff_time) { >>>> # To frequent updates, log to syslog. >>>> - &_log_to_syslog(" Skipping $blocklist blocklist - Too frequent u= pdate attempts!"); >>>> + # &_log_to_syslog(" Skipping $blocklist blocklist - Too frequent= update attempts!"); >>>> >>>> # Skip this provider. >>>> next; >>>> @@ -100,7 +100,7 @@ foreach my $blocklist (@blocklists) { >>>> # Handle different return codes. >>>> if ($return eq "not_modified") { >>>> # Log notice to syslog. >>>> - &_log_to_syslog(" Skipping $blocklist blocklist - It has not bee= n modified!"); >>>> + # &_log_to_syslog(" Skipping $blocklist blocklist - It has not b= een modified!"); >>>> } elsif ($return eq "dl_error") { >>>> # Log error to the syslog. >>>> &_log_to_syslog(" Could not update $blocklist blocklist - Downloa= d error\!"); >> The log message about not being modified was what a forum user was able to= use to identify that the Alien Vault list had not been updated for at least = 17 months. >> That information could not be found from the Alien Vault site as there is = no timestamp on the file being downloaded to be able to be processed. >> >=20 > Adolf - I did not change the ` Successfully updated ...` so a user sh= ould be able make a determination something stopped. >=20 >> I would not want to lose this information otherwise when another provider = silently closes their list because they have been taken over or decide to con= centrate on funded lists it will prove very hard to figure out if the lists a= re still active, even more so as more lists get added. >> >=20 > See my "troubleshooting" comment above. >=20 >> Regards, >> Adolf. >> >> >>>> --=20 >>>> 2.30.2 >>>> >> >> --=20 >> Sent from my laptop >> >=20 --===============1145441317614519129==--