From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH 2/3] whois: Installation of aan actively maintained whois client
Date: Fri, 06 Aug 2021 17:09:10 +0200
Message-ID: <3c9ed418-45e3-6e83-23a1-0ee93955532c@ipfire.org>
In-Reply-To: <20210806111642.3465624-2-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2423287395645501914=="
List-Id: <development.lists.ipfire.org>

--===============2423287395645501914==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Adolf,

excellent work. Thank you so much. :-)

Reviewed-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

Thanks, and best regards,
Peter M=C3=BCller


> - This whois client is being actively maintained. This version 5.5.10 was r=
eleased on
>    June 6th 2021 and regular updates have been ocurring several times per y=
ear.
> - This client has all of its default whois servers compiled into it. These =
can be seen
>    by reading the source files in the tarball.
> - Therefore the whois.conf file is available for any additional servers tha=
t are decided
>    to be required but as provided is empty.
> - Installed on a vm testbed and worked to identify the details of ip addres=
ses. Selecting
>    an IP in the WUI logs screen also gets the ip information provided so it=
 is working
>    well with the WUI.
>=20
> Tested-by:Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>  config/rootfiles/common/whois |  4 ++
>  lfs/whois                     | 84 +++++++++++++++++++++++++++++++++++
>  2 files changed, 88 insertions(+)
>  create mode 100644 config/rootfiles/common/whois
>  create mode 100644 lfs/whois
>=20
> diff --git a/config/rootfiles/common/whois b/config/rootfiles/common/whois
> new file mode 100644
> index 000000000..c5a16daf1
> --- /dev/null
> +++ b/config/rootfiles/common/whois
> @@ -0,0 +1,4 @@
> +etc/whois.conf
> +usr/bin/whois
> +#usr/share/man/man1/whois.1
> +#usr/share/man/man5/whois.conf.5
> diff --git a/lfs/whois b/lfs/whois
> new file mode 100644
> index 000000000..b526b90f4
> --- /dev/null
> +++ b/lfs/whois
> @@ -0,0 +1,84 @@
> +##########################################################################=
#####
> +#                                                                         =
    #
> +# IPFire.org - A linux based firewall                                     =
    #
> +# Copyright (C) 2007-2018  IPFire Team  <info(a)ipfire.org>               =
      #
> +#                                                                         =
    #
> +# This program is free software: you can redistribute it and/or modify    =
    #
> +# it under the terms of the GNU General Public License as published by    =
    #
> +# the Free Software Foundation, either version 3 of the License, or       =
    #
> +# (at your option) any later version.                                     =
    #
> +#                                                                         =
    #
> +# This program is distributed in the hope that it will be useful,         =
    #
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of          =
    #
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the           =
    #
> +# GNU General Public License for more details.                            =
    #
> +#                                                                         =
    #
> +# You should have received a copy of the GNU General Public License       =
    #
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.   =
    #
> +#                                                                         =
    #
> +##########################################################################=
#####
> +
> +##########################################################################=
#####
> +# Definitions
> +##########################################################################=
#####
> +
> +include Config
> +
> +VER        =3D 5.5.10
> +
> +THISAPP    =3D whois_$(VER)
> +DL_FILE    =3D $(THISAPP).tar.xz
> +DL_FROM    =3D $(URL_IPFIRE)
> +DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
> +TARGET     =3D $(DIR_INFO)/$(THISAPP)
> +
> +PROG       =3D whois
> +
> +##########################################################################=
#####
> +# Top-level Rules
> +##########################################################################=
#####
> +
> +objects =3D $(DL_FILE)
> +
> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
> +
> +$(DL_FILE)_MD5 =3D 4db48a482a06261ffa358d9f52c9bd7e
> +
> +install : $(TARGET)
> +
> +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> +
> +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> +
> +md5 : $(subst %,%_MD5,$(objects))
> +
> +##########################################################################=
#####
> +# Downloading, checking, md5sum
> +##########################################################################=
#####
> +
> +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> +	@$(CHECK)
> +
> +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> +	@$(LOAD)
> +
> +$(subst %,%_MD5,$(objects)) :
> +	@$(MD5)
> +
> +##########################################################################=
#####
> +# Installation Details
> +##########################################################################=
#####
> +
> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> +	@$(PREBUILD)
> +	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> +	$(UPDATE_AUTOMAKE)
> +
> +	cd $(DIR_SRC)/$(PROG) && make $(MAKETUNING) \
> +	                            CONFIG_FILE=3D/etc/whois.conf \
> +	                            whois
> +	cd $(DIR_SRC)/$(PROG) && make prefix=3D/usr install-whois
> +	cd $(DIR_SRC)/$(PROG) && install -v -m 644 whois.conf -t /etc/
> +
> +	@rm -rf $(DIR_APP)
> +	@$(POSTBUILD)
>=20

--===============2423287395645501914==--