From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] make.sh: Removal of four python2 modules
Date: Fri, 14 May 2021 09:06:48 +0200 [thread overview]
Message-ID: <3dc97242-f732-3eb6-471b-c45200890614@ipfire.org> (raw)
In-Reply-To: <20210513114331.3523287-1-adolf.belka@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 18797 bytes --]
Hello Adolf,
thanks for this patch. I wholeheartedly agree.
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
Thanks, and best regards,
Peter Müller
> - Removal of python-clientform, python-feedparser, python-mechanize
> and python-rssdler addons - lfs and rootfiles
> - python-clientform was made obsolete in 2008 and its functions taken
> over by python-mechanize
> - python-rssdler is an RSS feed downloader to facilitate downloading of
> podcasts, videocasts and torrents. Current IPFire version is 0.4.0a
> from 2008. The most recent version available is 0.4.2 from 2009. No
> further development is being done with this module. An RSS feed
> downloader is not appropriate for use in a firewall system, even
> less so when it is 12 years old.
> - python-feedparser and python-mechanize are both dependencies for
> python-rssdler. They are not dependencies for any other addon.
> - Full clean build with these four modules fully removed gave no problems.
>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/rootfiles/packages/python-clientform | 1 -
> config/rootfiles/packages/python-feedparser | 3 -
> config/rootfiles/packages/python-mechanize | 1 -
> config/rootfiles/packages/python-rssdler | 5 --
> lfs/python-clientform | 82 ---------------------
> lfs/python-feedparser | 82 ---------------------
> lfs/python-mechanize | 82 ---------------------
> lfs/python-rssdler | 82 ---------------------
> make.sh | 4 -
> 9 files changed, 342 deletions(-)
> delete mode 100644 config/rootfiles/packages/python-clientform
> delete mode 100644 config/rootfiles/packages/python-feedparser
> delete mode 100644 config/rootfiles/packages/python-mechanize
> delete mode 100644 config/rootfiles/packages/python-rssdler
> delete mode 100644 lfs/python-clientform
> delete mode 100644 lfs/python-feedparser
> delete mode 100644 lfs/python-mechanize
> delete mode 100644 lfs/python-rssdler
>
> diff --git a/config/rootfiles/packages/python-clientform b/config/rootfiles/packages/python-clientform
> deleted file mode 100644
> index 85a0d03ea..000000000
> --- a/config/rootfiles/packages/python-clientform
> +++ /dev/null
> @@ -1 +0,0 @@
> -usr/lib/python2.7/site-packages/ClientForm-0.2.9-py2.7.egg
> diff --git a/config/rootfiles/packages/python-feedparser b/config/rootfiles/packages/python-feedparser
> deleted file mode 100644
> index 88dbf1fc3..000000000
> --- a/config/rootfiles/packages/python-feedparser
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#usr/lib/python2.7/site-packages/feedparser-4.1-py2.7.egg-info
> -#usr/lib/python2.7/site-packages/feedparser.py
> -usr/lib/python2.7/site-packages/feedparser.pyc
> diff --git a/config/rootfiles/packages/python-mechanize b/config/rootfiles/packages/python-mechanize
> deleted file mode 100644
> index 5b5bf6a47..000000000
> --- a/config/rootfiles/packages/python-mechanize
> +++ /dev/null
> @@ -1 +0,0 @@
> -usr/lib/python2.7/site-packages/mechanize-0.1.8-py2.7.egg
> diff --git a/config/rootfiles/packages/python-rssdler b/config/rootfiles/packages/python-rssdler
> deleted file mode 100644
> index e5e3e3bdc..000000000
> --- a/config/rootfiles/packages/python-rssdler
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -usr/bin/rssdler
> -#usr/lib/python2.7/site-packages/drv_libxml2.pyc
> -#usr/lib/python2.7/site-packages/rssdler-0.4.0-py2.7.egg-info
> -usr/lib/python2.7/site-packages/rssdler.py
> -#usr/lib/python2.7/site-packages/rssdler.pyc
> diff --git a/lfs/python-clientform b/lfs/python-clientform
> deleted file mode 100644
> index 29804a969..000000000
> --- a/lfs/python-clientform
> +++ /dev/null
> @@ -1,82 +0,0 @@
> -###############################################################################
> -# #
> -# IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2018 IPFire Team <info(a)ipfire.org> #
> -# #
> -# This program is free software: you can redistribute it and/or modify #
> -# it under the terms of the GNU General Public License as published by #
> -# the Free Software Foundation, either version 3 of the License, or #
> -# (at your option) any later version. #
> -# #
> -# This program is distributed in the hope that it will be useful, #
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of #
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
> -# GNU General Public License for more details. #
> -# #
> -# You should have received a copy of the GNU General Public License #
> -# along with this program. If not, see <http://www.gnu.org/licenses/>. #
> -# #
> -###############################################################################
> -
> -###############################################################################
> -# Definitions
> -###############################################################################
> -
> -include Config
> -
> -VER = 0.2.9
> -
> -THISAPP = ClientForm-$(VER)
> -DL_FILE = $(THISAPP).tar.gz
> -DL_FROM = $(URL_IPFIRE)
> -DIR_APP = $(DIR_SRC)/$(THISAPP)
> -TARGET = $(DIR_INFO)/$(THISAPP)
> -PROG = python-clientform
> -PAK_VER = 2
> -
> -DEPS =
> -
> -###############################################################################
> -# Top-level Rules
> -###############################################################################
> -
> -objects = $(DL_FILE)
> -
> -$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> -
> -$(DL_FILE)_MD5 = 21e68d52cc5939ab3345b97e09f0a25a
> -
> -install : $(TARGET)
> -
> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> -
> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
> -
> -md5 : $(subst %,%_MD5,$(objects))
> -
> -dist:
> - @$(PAK)
> -
> -###############################################################################
> -# Downloading, checking, md5sum
> -###############################################################################
> -
> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> - @$(CHECK)
> -
> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
> - @$(LOAD)
> -
> -$(subst %,%_MD5,$(objects)) :
> - @$(MD5)
> -
> -###############################################################################
> -# Installation Details
> -###############################################################################
> -
> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> - @$(PREBUILD)
> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
> - cd $(DIR_APP) && python setup.py install
> - @rm -rf $(DIR_APP)
> - @$(POSTBUILD)
> diff --git a/lfs/python-feedparser b/lfs/python-feedparser
> deleted file mode 100644
> index e89018d0a..000000000
> --- a/lfs/python-feedparser
> +++ /dev/null
> @@ -1,82 +0,0 @@
> -###############################################################################
> -# #
> -# IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2018 IPFire Team <info(a)ipfire.org> #
> -# #
> -# This program is free software: you can redistribute it and/or modify #
> -# it under the terms of the GNU General Public License as published by #
> -# the Free Software Foundation, either version 3 of the License, or #
> -# (at your option) any later version. #
> -# #
> -# This program is distributed in the hope that it will be useful, #
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of #
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
> -# GNU General Public License for more details. #
> -# #
> -# You should have received a copy of the GNU General Public License #
> -# along with this program. If not, see <http://www.gnu.org/licenses/>. #
> -# #
> -###############################################################################
> -
> -###############################################################################
> -# Definitions
> -###############################################################################
> -
> -include Config
> -
> -VER = 4.1
> -
> -THISAPP = feedparser-$(VER)
> -DL_FILE = $(THISAPP).tar.gz
> -DL_FROM = $(URL_IPFIRE)
> -DIR_APP = $(DIR_SRC)/$(THISAPP)
> -TARGET = $(DIR_INFO)/$(THISAPP)
> -PROG = python-feedparser
> -PAK_VER = 2
> -
> -DEPS = python-mechanize
> -
> -###############################################################################
> -# Top-level Rules
> -###############################################################################
> -
> -objects = $(DL_FILE)
> -
> -$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> -
> -$(DL_FILE)_MD5 = a8fcb5fd0868e34271fc182d6ae03801
> -
> -install : $(TARGET)
> -
> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> -
> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
> -
> -md5 : $(subst %,%_MD5,$(objects))
> -
> -dist:
> - @$(PAK)
> -
> -###############################################################################
> -# Downloading, checking, md5sum
> -###############################################################################
> -
> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> - @$(CHECK)
> -
> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
> - @$(LOAD)
> -
> -$(subst %,%_MD5,$(objects)) :
> - @$(MD5)
> -
> -###############################################################################
> -# Installation Details
> -###############################################################################
> -
> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> - @$(PREBUILD)
> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
> - cd $(DIR_APP) && python setup.py install
> - @rm -rf $(DIR_APP)
> - @$(POSTBUILD)
> diff --git a/lfs/python-mechanize b/lfs/python-mechanize
> deleted file mode 100644
> index 8a879bc1c..000000000
> --- a/lfs/python-mechanize
> +++ /dev/null
> @@ -1,82 +0,0 @@
> -###############################################################################
> -# #
> -# IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2018 IPFire Team <info(a)ipfire.org> #
> -# #
> -# This program is free software: you can redistribute it and/or modify #
> -# it under the terms of the GNU General Public License as published by #
> -# the Free Software Foundation, either version 3 of the License, or #
> -# (at your option) any later version. #
> -# #
> -# This program is distributed in the hope that it will be useful, #
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of #
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
> -# GNU General Public License for more details. #
> -# #
> -# You should have received a copy of the GNU General Public License #
> -# along with this program. If not, see <http://www.gnu.org/licenses/>. #
> -# #
> -###############################################################################
> -
> -###############################################################################
> -# Definitions
> -###############################################################################
> -
> -include Config
> -
> -VER = 0.1.8
> -
> -THISAPP = mechanize-$(VER)
> -DL_FILE = $(THISAPP).tar.gz
> -DL_FROM = $(URL_IPFIRE)
> -DIR_APP = $(DIR_SRC)/$(THISAPP)
> -TARGET = $(DIR_INFO)/$(THISAPP)
> -PROG = python-mechanize
> -PAK_VER = 2
> -
> -DEPS = python-clientform
> -
> -###############################################################################
> -# Top-level Rules
> -###############################################################################
> -
> -objects = $(DL_FILE)
> -
> -$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> -
> -$(DL_FILE)_MD5 = 0a9edfcbb3b631fc75451909af78cf7a
> -
> -install : $(TARGET)
> -
> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> -
> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
> -
> -md5 : $(subst %,%_MD5,$(objects))
> -
> -dist:
> - @$(PAK)
> -
> -###############################################################################
> -# Downloading, checking, md5sum
> -###############################################################################
> -
> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> - @$(CHECK)
> -
> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
> - @$(LOAD)
> -
> -$(subst %,%_MD5,$(objects)) :
> - @$(MD5)
> -
> -###############################################################################
> -# Installation Details
> -###############################################################################
> -
> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> - @$(PREBUILD)
> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
> - cd $(DIR_APP) && python setup.py install
> - @rm -rf $(DIR_APP)
> - @$(POSTBUILD)
> diff --git a/lfs/python-rssdler b/lfs/python-rssdler
> deleted file mode 100644
> index 2b73a2774..000000000
> --- a/lfs/python-rssdler
> +++ /dev/null
> @@ -1,82 +0,0 @@
> -###############################################################################
> -# #
> -# IPFire.org - A linux based firewall #
> -# Copyright (C) 2007-2018 IPFire Team <info(a)ipfire.org> #
> -# #
> -# This program is free software: you can redistribute it and/or modify #
> -# it under the terms of the GNU General Public License as published by #
> -# the Free Software Foundation, either version 3 of the License, or #
> -# (at your option) any later version. #
> -# #
> -# This program is distributed in the hope that it will be useful, #
> -# but WITHOUT ANY WARRANTY; without even the implied warranty of #
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the #
> -# GNU General Public License for more details. #
> -# #
> -# You should have received a copy of the GNU General Public License #
> -# along with this program. If not, see <http://www.gnu.org/licenses/>. #
> -# #
> -###############################################################################
> -
> -###############################################################################
> -# Definitions
> -###############################################################################
> -
> -include Config
> -
> -VER = 0.4.0a
> -
> -THISAPP = rssdler-$(VER)
> -DL_FILE = $(THISAPP).tar.gz
> -DL_FROM = $(URL_IPFIRE)
> -DIR_APP = $(DIR_SRC)/rssdler040
> -TARGET = $(DIR_INFO)/$(THISAPP)
> -PROG = python-rssdler
> -PAK_VER = 2
> -
> -DEPS = python-feedparser python-mechanize
> -
> -###############################################################################
> -# Top-level Rules
> -###############################################################################
> -
> -objects = $(DL_FILE)
> -
> -$(DL_FILE) = $(DL_FROM)/$(DL_FILE)
> -
> -$(DL_FILE)_MD5 = 367fa2770a689b0d64003f8c94213a80
> -
> -install : $(TARGET)
> -
> -check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> -
> -download :$(patsubst %,$(DIR_DL)/%,$(objects))
> -
> -md5 : $(subst %,%_MD5,$(objects))
> -
> -dist:
> - @$(PAK)
> -
> -###############################################################################
> -# Downloading, checking, md5sum
> -###############################################################################
> -
> -$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> - @$(CHECK)
> -
> -$(patsubst %,$(DIR_DL)/%,$(objects)) :
> - @$(LOAD)
> -
> -$(subst %,%_MD5,$(objects)) :
> - @$(MD5)
> -
> -###############################################################################
> -# Installation Details
> -###############################################################################
> -
> -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> - @$(PREBUILD)
> - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
> - cd $(DIR_APP) && python setup.py install
> - @rm -rf $(DIR_APP)
> - @$(POSTBUILD)
> diff --git a/make.sh b/make.sh
> index 25616cc4e..37c201c4e 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1345,10 +1345,6 @@ buildipfire() {
> lfsmake2 Crypt-PasswdMD5
> lfsmake2 Net-Telnet
> lfsmake2 python-setuptools
> - lfsmake2 python-clientform
> - lfsmake2 python-mechanize
> - lfsmake2 python-feedparser
> - lfsmake2 python-rssdler
> lfsmake2 python-inotify
> lfsmake2 python-docutils
> lfsmake2 python-daemon
>
prev parent reply other threads:[~2021-05-14 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 11:43 Adolf Belka
2021-05-14 7:06 ` Peter Müller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dc97242-f732-3eb6-471b-c45200890614@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox