From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: [PATCH] make.sh: Removal of four python2 modules Date: Fri, 14 May 2021 09:06:48 +0200 Message-ID: <3dc97242-f732-3eb6-471b-c45200890614@ipfire.org> In-Reply-To: <20210513114331.3523287-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1883676125043207458==" List-Id: --===============1883676125043207458== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Adolf, thanks for this patch. I wholeheartedly agree. Reviewed-by: Peter M=C3=BCller Thanks, and best regards, Peter M=C3=BCller > - Removal of python-clientform, python-feedparser, python-mechanize > and python-rssdler addons - lfs and rootfiles > - python-clientform was made obsolete in 2008 and its functions taken > over by python-mechanize > - python-rssdler is an RSS feed downloader to facilitate downloading of > podcasts, videocasts and torrents. Current IPFire version is 0.4.0a > from 2008. The most recent version available is 0.4.2 from 2009. No > further development is being done with this module. An RSS feed > downloader is not appropriate for use in a firewall system, even > less so when it is 12 years old. > - python-feedparser and python-mechanize are both dependencies for > python-rssdler. They are not dependencies for any other addon. > - Full clean build with these four modules fully removed gave no problems. >=20 > Signed-off-by: Adolf Belka > --- > config/rootfiles/packages/python-clientform | 1 - > config/rootfiles/packages/python-feedparser | 3 - > config/rootfiles/packages/python-mechanize | 1 - > config/rootfiles/packages/python-rssdler | 5 -- > lfs/python-clientform | 82 --------------------- > lfs/python-feedparser | 82 --------------------- > lfs/python-mechanize | 82 --------------------- > lfs/python-rssdler | 82 --------------------- > make.sh | 4 - > 9 files changed, 342 deletions(-) > delete mode 100644 config/rootfiles/packages/python-clientform > delete mode 100644 config/rootfiles/packages/python-feedparser > delete mode 100644 config/rootfiles/packages/python-mechanize > delete mode 100644 config/rootfiles/packages/python-rssdler > delete mode 100644 lfs/python-clientform > delete mode 100644 lfs/python-feedparser > delete mode 100644 lfs/python-mechanize > delete mode 100644 lfs/python-rssdler >=20 > diff --git a/config/rootfiles/packages/python-clientform b/config/rootfiles= /packages/python-clientform > deleted file mode 100644 > index 85a0d03ea..000000000 > --- a/config/rootfiles/packages/python-clientform > +++ /dev/null > @@ -1 +0,0 @@ > -usr/lib/python2.7/site-packages/ClientForm-0.2.9-py2.7.egg > diff --git a/config/rootfiles/packages/python-feedparser b/config/rootfiles= /packages/python-feedparser > deleted file mode 100644 > index 88dbf1fc3..000000000 > --- a/config/rootfiles/packages/python-feedparser > +++ /dev/null > @@ -1,3 +0,0 @@ > -#usr/lib/python2.7/site-packages/feedparser-4.1-py2.7.egg-info > -#usr/lib/python2.7/site-packages/feedparser.py > -usr/lib/python2.7/site-packages/feedparser.pyc > diff --git a/config/rootfiles/packages/python-mechanize b/config/rootfiles/= packages/python-mechanize > deleted file mode 100644 > index 5b5bf6a47..000000000 > --- a/config/rootfiles/packages/python-mechanize > +++ /dev/null > @@ -1 +0,0 @@ > -usr/lib/python2.7/site-packages/mechanize-0.1.8-py2.7.egg > diff --git a/config/rootfiles/packages/python-rssdler b/config/rootfiles/pa= ckages/python-rssdler > deleted file mode 100644 > index e5e3e3bdc..000000000 > --- a/config/rootfiles/packages/python-rssdler > +++ /dev/null > @@ -1,5 +0,0 @@ > -usr/bin/rssdler > -#usr/lib/python2.7/site-packages/drv_libxml2.pyc > -#usr/lib/python2.7/site-packages/rssdler-0.4.0-py2.7.egg-info > -usr/lib/python2.7/site-packages/rssdler.py > -#usr/lib/python2.7/site-packages/rssdler.pyc > diff --git a/lfs/python-clientform b/lfs/python-clientform > deleted file mode 100644 > index 29804a969..000000000 > --- a/lfs/python-clientform > +++ /dev/null > @@ -1,82 +0,0 @@ > -##########################################################################= ##### > -# = # > -# IPFire.org - A linux based firewall = # > -# Copyright (C) 2007-2018 IPFire Team = # > -# = # > -# This program is free software: you can redistribute it and/or modify = # > -# it under the terms of the GNU General Public License as published by = # > -# the Free Software Foundation, either version 3 of the License, or = # > -# (at your option) any later version. = # > -# = # > -# This program is distributed in the hope that it will be useful, = # > -# but WITHOUT ANY WARRANTY; without even the implied warranty of = # > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # > -# GNU General Public License for more details. = # > -# = # > -# You should have received a copy of the GNU General Public License = # > -# along with this program. If not, see . = # > -# = # > -##########################################################################= ##### > - > -##########################################################################= ##### > -# Definitions > -##########################################################################= ##### > - > -include Config > - > -VER =3D 0.2.9 > - > -THISAPP =3D ClientForm-$(VER) > -DL_FILE =3D $(THISAPP).tar.gz > -DL_FROM =3D $(URL_IPFIRE) > -DIR_APP =3D $(DIR_SRC)/$(THISAPP) > -TARGET =3D $(DIR_INFO)/$(THISAPP) > -PROG =3D python-clientform > -PAK_VER =3D 2 > - > -DEPS =3D > - > -##########################################################################= ##### > -# Top-level Rules > -##########################################################################= ##### > - > -objects =3D $(DL_FILE) > - > -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) > - > -$(DL_FILE)_MD5 =3D 21e68d52cc5939ab3345b97e09f0a25a > - > -install : $(TARGET) > - > -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > - > -download :$(patsubst %,$(DIR_DL)/%,$(objects)) > - > -md5 : $(subst %,%_MD5,$(objects)) > - > -dist:=20 > - @$(PAK) > - > -##########################################################################= ##### > -# Downloading, checking, md5sum > -##########################################################################= ##### > - > -$(patsubst %,$(DIR_CHK)/%,$(objects)) : > - @$(CHECK) > - > -$(patsubst %,$(DIR_DL)/%,$(objects)) : > - @$(LOAD) > - > -$(subst %,%_MD5,$(objects)) : > - @$(MD5) > - > -##########################################################################= ##### > -# Installation Details > -##########################################################################= ##### > - > -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > - @$(PREBUILD) > - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) > - cd $(DIR_APP) && python setup.py install > - @rm -rf $(DIR_APP) > - @$(POSTBUILD) > diff --git a/lfs/python-feedparser b/lfs/python-feedparser > deleted file mode 100644 > index e89018d0a..000000000 > --- a/lfs/python-feedparser > +++ /dev/null > @@ -1,82 +0,0 @@ > -##########################################################################= ##### > -# = # > -# IPFire.org - A linux based firewall = # > -# Copyright (C) 2007-2018 IPFire Team = # > -# = # > -# This program is free software: you can redistribute it and/or modify = # > -# it under the terms of the GNU General Public License as published by = # > -# the Free Software Foundation, either version 3 of the License, or = # > -# (at your option) any later version. = # > -# = # > -# This program is distributed in the hope that it will be useful, = # > -# but WITHOUT ANY WARRANTY; without even the implied warranty of = # > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # > -# GNU General Public License for more details. = # > -# = # > -# You should have received a copy of the GNU General Public License = # > -# along with this program. If not, see . = # > -# = # > -##########################################################################= ##### > - > -##########################################################################= ##### > -# Definitions > -##########################################################################= ##### > - > -include Config > - > -VER =3D 4.1 > - > -THISAPP =3D feedparser-$(VER) > -DL_FILE =3D $(THISAPP).tar.gz > -DL_FROM =3D $(URL_IPFIRE) > -DIR_APP =3D $(DIR_SRC)/$(THISAPP) > -TARGET =3D $(DIR_INFO)/$(THISAPP) > -PROG =3D python-feedparser > -PAK_VER =3D 2 > - > -DEPS =3D python-mechanize > - > -##########################################################################= ##### > -# Top-level Rules > -##########################################################################= ##### > - > -objects =3D $(DL_FILE) > - > -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) > - > -$(DL_FILE)_MD5 =3D a8fcb5fd0868e34271fc182d6ae03801 > - > -install : $(TARGET) > - > -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > - > -download :$(patsubst %,$(DIR_DL)/%,$(objects)) > - > -md5 : $(subst %,%_MD5,$(objects)) > - > -dist:=20 > - @$(PAK) > - > -##########################################################################= ##### > -# Downloading, checking, md5sum > -##########################################################################= ##### > - > -$(patsubst %,$(DIR_CHK)/%,$(objects)) : > - @$(CHECK) > - > -$(patsubst %,$(DIR_DL)/%,$(objects)) : > - @$(LOAD) > - > -$(subst %,%_MD5,$(objects)) : > - @$(MD5) > - > -##########################################################################= ##### > -# Installation Details > -##########################################################################= ##### > - > -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > - @$(PREBUILD) > - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) > - cd $(DIR_APP) && python setup.py install > - @rm -rf $(DIR_APP) > - @$(POSTBUILD) > diff --git a/lfs/python-mechanize b/lfs/python-mechanize > deleted file mode 100644 > index 8a879bc1c..000000000 > --- a/lfs/python-mechanize > +++ /dev/null > @@ -1,82 +0,0 @@ > -##########################################################################= ##### > -# = # > -# IPFire.org - A linux based firewall = # > -# Copyright (C) 2007-2018 IPFire Team = # > -# = # > -# This program is free software: you can redistribute it and/or modify = # > -# it under the terms of the GNU General Public License as published by = # > -# the Free Software Foundation, either version 3 of the License, or = # > -# (at your option) any later version. = # > -# = # > -# This program is distributed in the hope that it will be useful, = # > -# but WITHOUT ANY WARRANTY; without even the implied warranty of = # > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # > -# GNU General Public License for more details. = # > -# = # > -# You should have received a copy of the GNU General Public License = # > -# along with this program. If not, see . = # > -# = # > -##########################################################################= ##### > - > -##########################################################################= ##### > -# Definitions > -##########################################################################= ##### > - > -include Config > - > -VER =3D 0.1.8 > - > -THISAPP =3D mechanize-$(VER) > -DL_FILE =3D $(THISAPP).tar.gz > -DL_FROM =3D $(URL_IPFIRE) > -DIR_APP =3D $(DIR_SRC)/$(THISAPP) > -TARGET =3D $(DIR_INFO)/$(THISAPP) > -PROG =3D python-mechanize > -PAK_VER =3D 2 > - > -DEPS =3D python-clientform > - > -##########################################################################= ##### > -# Top-level Rules > -##########################################################################= ##### > - > -objects =3D $(DL_FILE) > - > -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) > - > -$(DL_FILE)_MD5 =3D 0a9edfcbb3b631fc75451909af78cf7a > - > -install : $(TARGET) > - > -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > - > -download :$(patsubst %,$(DIR_DL)/%,$(objects)) > - > -md5 : $(subst %,%_MD5,$(objects)) > - > -dist:=20 > - @$(PAK) > - > -##########################################################################= ##### > -# Downloading, checking, md5sum > -##########################################################################= ##### > - > -$(patsubst %,$(DIR_CHK)/%,$(objects)) : > - @$(CHECK) > - > -$(patsubst %,$(DIR_DL)/%,$(objects)) : > - @$(LOAD) > - > -$(subst %,%_MD5,$(objects)) : > - @$(MD5) > - > -##########################################################################= ##### > -# Installation Details > -##########################################################################= ##### > - > -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > - @$(PREBUILD) > - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) > - cd $(DIR_APP) && python setup.py install > - @rm -rf $(DIR_APP) > - @$(POSTBUILD) > diff --git a/lfs/python-rssdler b/lfs/python-rssdler > deleted file mode 100644 > index 2b73a2774..000000000 > --- a/lfs/python-rssdler > +++ /dev/null > @@ -1,82 +0,0 @@ > -##########################################################################= ##### > -# = # > -# IPFire.org - A linux based firewall = # > -# Copyright (C) 2007-2018 IPFire Team = # > -# = # > -# This program is free software: you can redistribute it and/or modify = # > -# it under the terms of the GNU General Public License as published by = # > -# the Free Software Foundation, either version 3 of the License, or = # > -# (at your option) any later version. = # > -# = # > -# This program is distributed in the hope that it will be useful, = # > -# but WITHOUT ANY WARRANTY; without even the implied warranty of = # > -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the = # > -# GNU General Public License for more details. = # > -# = # > -# You should have received a copy of the GNU General Public License = # > -# along with this program. If not, see . = # > -# = # > -##########################################################################= ##### > - > -##########################################################################= ##### > -# Definitions > -##########################################################################= ##### > - > -include Config > - > -VER =3D 0.4.0a > - > -THISAPP =3D rssdler-$(VER) > -DL_FILE =3D $(THISAPP).tar.gz > -DL_FROM =3D $(URL_IPFIRE) > -DIR_APP =3D $(DIR_SRC)/rssdler040 > -TARGET =3D $(DIR_INFO)/$(THISAPP) > -PROG =3D python-rssdler > -PAK_VER =3D 2 > - > -DEPS =3D python-feedparser python-mechanize > - > -##########################################################################= ##### > -# Top-level Rules > -##########################################################################= ##### > - > -objects =3D $(DL_FILE) > - > -$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE) > - > -$(DL_FILE)_MD5 =3D 367fa2770a689b0d64003f8c94213a80 > - > -install : $(TARGET) > - > -check : $(patsubst %,$(DIR_CHK)/%,$(objects)) > - > -download :$(patsubst %,$(DIR_DL)/%,$(objects)) > - > -md5 : $(subst %,%_MD5,$(objects)) > - > -dist:=20 > - @$(PAK) > - > -##########################################################################= ##### > -# Downloading, checking, md5sum > -##########################################################################= ##### > - > -$(patsubst %,$(DIR_CHK)/%,$(objects)) : > - @$(CHECK) > - > -$(patsubst %,$(DIR_DL)/%,$(objects)) : > - @$(LOAD) > - > -$(subst %,%_MD5,$(objects)) : > - @$(MD5) > - > -##########################################################################= ##### > -# Installation Details > -##########################################################################= ##### > - > -$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects)) > - @$(PREBUILD) > - @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE) > - cd $(DIR_APP) && python setup.py install > - @rm -rf $(DIR_APP) > - @$(POSTBUILD) > diff --git a/make.sh b/make.sh > index 25616cc4e..37c201c4e 100755 > --- a/make.sh > +++ b/make.sh > @@ -1345,10 +1345,6 @@ buildipfire() { > lfsmake2 Crypt-PasswdMD5 > lfsmake2 Net-Telnet > lfsmake2 python-setuptools > - lfsmake2 python-clientform > - lfsmake2 python-mechanize > - lfsmake2 python-feedparser > - lfsmake2 python-rssdler > lfsmake2 python-inotify > lfsmake2 python-docutils > lfsmake2 python-daemon >=20 --===============1883676125043207458==--