From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] header.pl: Add reference to colors.txt into header.pl
Date: Fri, 17 Mar 2023 17:11:57 +0100
Message-ID: <3dff265c-1010-ab75-9ac5-690670d5ab4b@ipfire.org>
In-Reply-To: <20230316103403.3761-1-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4708001564932944649=="
List-Id: <development.lists.ipfire.org>

--===============4708001564932944649==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>
Tested-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 16.03.2023 um 11:34 schrieb Adolf Belka:
> - With change of common css entries into header.pl with commit
>     https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommit;h=3Db52a84ddc77f9=
db7e4ad7b129f21fbf528c6f990
>     I had missed that color20 and color22 etc, that come from colors.txt, a=
re not known in
>     header.pl so that the alternate colours in tables were missing. Even th=
ough I tested the
>     previous commit I obviously did not look well enough because I missed t=
hat the tables
>     had no alternate colours. I just found it now when looking at Core Upda=
te 174 Testing.
> - Confirmed by copying this version of header.pl into my CU174 Testing syst=
em and the
>     alternate colour rows came back again as they should be. I am sure now =
that they are
>     correct.
>=20
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   config/cfgroot/header.pl | 3 +++
>   1 file changed, 3 insertions(+)
>=20
> diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
> index 955ed2646..3f80ce9b4 100644
> --- a/config/cfgroot/header.pl
> +++ b/config/cfgroot/header.pl
> @@ -17,6 +17,9 @@ use HTML::Entities();
>   use Socket;
>   use Time::Local;
>  =20
> +our %color =3D ();
> +&General::readhash("/srv/web/ipfire/html/themes/ipfire/include/colors.txt"=
, \%color);
> +
>   $|=3D1; # line buffering
>  =20
>   $Header::revision =3D 'final';

--===============4708001564932944649==--