From: "Peter Müller" <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/3] linux-firmware: Drop hack to remove spaces in filenames
Date: Wed, 18 Jan 2023 23:25:54 +0000 [thread overview]
Message-ID: <3ed792cd-9e43-43e8-fb72-5bdafb3a0bb8@ipfire.org> (raw)
In-Reply-To: <20230118113628.3309496-2-michael.tremer@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 3868 bytes --]
Reviewed-by: Peter Müller <peter.mueller(a)ipfire.org>
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
> config/rootfiles/common/linux-firmware | 14 +++++++-------
> lfs/linux-firmware | 5 -----
> 2 files changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/config/rootfiles/common/linux-firmware b/config/rootfiles/common/linux-firmware
> index 4d73cc060..2e147afd1 100644
> --- a/config/rootfiles/common/linux-firmware
> +++ b/config/rootfiles/common/linux-firmware
> @@ -824,7 +824,7 @@ lib/firmware/brcm/brcmfmac43143-sdio.bin
> lib/firmware/brcm/brcmfmac43143.bin
> lib/firmware/brcm/brcmfmac43236b.bin
> lib/firmware/brcm/brcmfmac43241b0-sdio.bin
> -lib/firmware/brcm/brcmfmac43241b4-sdio.Intel_Corp.-VALLEYVIEW_C0_PLATFORM.txt
> +lib/firmware/brcm/brcmfmac43241b4-sdio.Intel Corp.-VALLEYVIEW C0 PLATFORM.txt
> lib/firmware/brcm/brcmfmac43241b4-sdio.bin
> lib/firmware/brcm/brcmfmac43241b5-sdio.bin
> lib/firmware/brcm/brcmfmac43242a.bin
> @@ -832,7 +832,7 @@ lib/firmware/brcm/brcmfmac4329-sdio.bin
> lib/firmware/brcm/brcmfmac4330-sdio.Prowise-PT301.txt
> lib/firmware/brcm/brcmfmac4330-sdio.bin
> lib/firmware/brcm/brcmfmac4334-sdio.bin
> -lib/firmware/brcm/brcmfmac43340-sdio.ASUSTeK_COMPUTER_INC.-TF103CE.txt
> +lib/firmware/brcm/brcmfmac43340-sdio.ASUSTeK COMPUTER INC.-TF103CE.txt
> lib/firmware/brcm/brcmfmac43340-sdio.bin
> lib/firmware/brcm/brcmfmac43340-sdio.meegopad-t08.txt
> lib/firmware/brcm/brcmfmac43340-sdio.pov-tab-p1006w-data.txt
> @@ -858,14 +858,14 @@ lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-ultra.txt
> lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m2-zero.txt
> lib/firmware/brcm/brcmfmac43430-sdio.sinovoip,bpi-m3.txt
> lib/firmware/brcm/brcmfmac43430-sdio.starfive,visionfive-v1.txt
> -lib/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80_PLUS.txt
> +lib/firmware/brcm/brcmfmac43430a0-sdio.ONDA-V80 PLUS.txt
> lib/firmware/brcm/brcmfmac43430a0-sdio.bin
> lib/firmware/brcm/brcmfmac43430a0-sdio.ilife-S806.txt
> lib/firmware/brcm/brcmfmac43430a0-sdio.jumper-ezpad-mini3.txt
> lib/firmware/brcm/brcmfmac43455-sdio.AW-CM256SM.txt
> -lib/firmware/brcm/brcmfmac43455-sdio.MINIX-NEO_Z83-4.txt
> -lib/firmware/brcm/brcmfmac43455-sdio.Raspberry_Pi_Foundation-Raspberry_Pi_4_Model_B.txt
> -lib/firmware/brcm/brcmfmac43455-sdio.Raspberry_Pi_Foundation-Raspberry_Pi_Compute_Module_4.txt
> +lib/firmware/brcm/brcmfmac43455-sdio.MINIX-NEO Z83-4.txt
> +lib/firmware/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi 4 Model B.txt
> +lib/firmware/brcm/brcmfmac43455-sdio.Raspberry Pi Foundation-Raspberry Pi Compute Module 4.txt
> lib/firmware/brcm/brcmfmac43455-sdio.acepc-t8.txt
> lib/firmware/brcm/brcmfmac43455-sdio.beagle,am5729-beagleboneai.txt
> lib/firmware/brcm/brcmfmac43455-sdio.bin
> @@ -880,7 +880,7 @@ lib/firmware/brcm/brcmfmac4350-pcie.bin
> lib/firmware/brcm/brcmfmac4350c2-pcie.bin
> lib/firmware/brcm/brcmfmac4354-sdio.bin
> lib/firmware/brcm/brcmfmac4354-sdio.clm_blob
> -lib/firmware/brcm/brcmfmac4356-pcie.Xiaomi_Inc-Mipad2.txt
> +lib/firmware/brcm/brcmfmac4356-pcie.Xiaomi Inc-Mipad2.txt
> lib/firmware/brcm/brcmfmac4356-pcie.bin
> lib/firmware/brcm/brcmfmac4356-pcie.clm_blob
> lib/firmware/brcm/brcmfmac4356-pcie.gpd-win-pocket.txt
> diff --git a/lfs/linux-firmware b/lfs/linux-firmware
> index 0a11eef8c..f234dce62 100644
> --- a/lfs/linux-firmware
> +++ b/lfs/linux-firmware
> @@ -73,11 +73,6 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> mkdir -p /lib/firmware
> cd $(DIR_APP) && make install
>
> - # Remove any spaces in filenames
> - while read -r file; do \
> - mv "$${file}" "$${file// /_}" || exit 1; \
> - done < <(find /lib/firmware -name "* *")
> -
> # Hardlink any identical files
> hardlink -c -vv /lib/firmware
>
next prev parent reply other threads:[~2023-01-18 23:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:36 [PATCH 1/3] Config: Support rootfiles with " Michael Tremer
2023-01-18 11:36 ` [PATCH 2/3] linux-firmware: Drop hack to remove " Michael Tremer
2023-01-18 23:25 ` Peter Müller [this message]
2023-01-18 11:36 ` [PATCH 3/3] rootfiles: Remove further spaces Michael Tremer
2023-01-18 23:26 ` Peter Müller
2023-01-18 23:25 ` [PATCH 1/3] Config: Support rootfiles with spaces in filenames Peter Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ed792cd-9e43-43e8-fb72-5bdafb3a0bb8@ipfire.org \
--to=peter.mueller@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox