From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <ahb.ipfire@gmail.com>
To: development@lists.ipfire.org
Subject: Re: [PATCH 1/2] sshfs: Update to 3.7.1
Date: Thu, 07 Jan 2021 14:34:00 +0100
Message-ID: <4033cb25-ed16-5d86-fed4-9dc14d5aba10@gmail.com>
In-Reply-To: <FF9E2CD1-2B63-423F-8463-7EECDD8A8BA2@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============5182930446041155842=="
List-Id: <development.lists.ipfire.org>

--===============5182930446041155842==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Michael,

On 07/01/2021 12:25, Michael Tremer wrote:
> Hi,
>=20
> In the Git repository of fuse, there is an initscript that loads the kernel=
 module when the system boots:
>=20
> https://github.com/libfuse/libfuse/blob/f54eb86e9a0b596dfeceb18277efa8f840d=
85919/util/init_script
>=20
> Maybe we want to integrate this.

That could be an option but the downside would be that the fuse module would =
then be enabled for all IPFire users, even if they are not using fuse. I thin=
k if people aren't using fuse on a firewall it is probably better to not load=
 it automatically.

As there have been no questions on IPFire Community about fuse not being load=
ed or any problems with sshfs then either no one is using sshfs and fuse or t=
hey have been able to figure it out.

My preference would be to leave it as it is.
I was going to say that I could update the wiki to mention about the need to =
run modprobe fuse but I found that sshfs is not mentioned anywhere in the wik=
i (at least the search came back with zero results).

Having found out about sshfs on IPFire, I will likely use it from time to tim=
e.

Regards,
Adolf

>=20
> -Michael
>=20
>> On 6 Jan 2021, at 19:21, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>
>> Hi Michael,
>>
>> I suddenly thought I should also check the old version on Core 153, so I d=
id that and the same thing happens. The fuse module is not loaded automatical=
ly when sshfs command is run, but the error message is very helpful.
>>
>> "fuse: device not found, try 'modprobe fuse' first"
>>
>> So the new sshfs version operates the same as the old one, so I am no long=
er so worried about this.
>>
>>
>> Regards,
>>
>> Adolf
>>
>> On 06/01/2021 19:39, Adolf Belka wrote:
>>> Hi,
>>>
>>>
>>> On 06/01/2021 16:30, Michael Tremer wrote:
>>>> Hi,
>>>>
>>>>> On 5 Jan 2021, at 14:28, Adolf Belka <ahb.ipfire(a)gmail.com> wrote:
>>>>>
>>>>> Dear all,
>>>>>
>>>>> Forgot to mention in the logs that I have also installed the built IPFi=
re with new fuse and sshfs into my testbed system and was able to setup an ss=
hfs mount from a remote computer into the IPFire system, so confirmed working.
>>>>>
>>>>> The only thing I had to do was run modprobe fuse as the fuse module was=
 not loaded. Is that normal to need to do or did I miss something when I was =
building sshfs/fuse
>>>>
>>>> I would expect that sshfs is doing that automatically.
>>>
>>> Then there may be a problem. When I ran the sshfs command I got a message=
 that it could not find fuse and it suggested that I should run modprobe fuse=
, which I did, and then the same sshfs command worked.
>>>
>>> Not sure how to find out why sshfs did not have the modprobe command run =
automatically or how to make it do so.
>>>
>>>>
>>>>> Regards,
>>>>> Adolf.
>>>>>
>>>>> On 05/01/2021 15:20, Adolf Belka wrote:
>>>>>> - Update sshfs from 2.2 to 3.7.1
>>>>>> - Changelog is available at https://github.com/libfuse/sshfs/releases
>>>>>> - Build had to be changed from autotools to meson/ninja
>>>>>> - Change in rootfiles
>>>>>> Signed-off-by: Adolf Belka <ahb.ipfire(a)gmail.com>
>>>>>> ---
>>>>>>    config/rootfiles/common/sshfs |  2 ++
>>>>>>    lfs/sshfs                     | 14 ++++++--------
>>>>>>    2 files changed, 8 insertions(+), 8 deletions(-)
>>>>>> diff --git a/config/rootfiles/common/sshfs b/config/rootfiles/common/s=
shfs
>>>>>> index 2cafa3e24..579b938f5 100644
>>>>>> --- a/config/rootfiles/common/sshfs
>>>>>> +++ b/config/rootfiles/common/sshfs
>>>>>> @@ -1,2 +1,4 @@
>>>>>>    usr/bin/sshfs
>>>>>> +#usr/sbin/mount.fuse.sshfs
>>>>>> +#usr/sbin/mount.sshfs
>>>>>>    #usr/share/man/man1/sshfs.1
>>>>>> diff --git a/lfs/sshfs b/lfs/sshfs
>>>>>> index 23fbd18ca..1e7706194 100644
>>>>>> --- a/lfs/sshfs
>>>>>> +++ b/lfs/sshfs
>>>>>> @@ -24,10 +24,10 @@
>>>>>>      include Config
>>>>>>    -VER        =3D 2.2
>>>>>> +VER        =3D 3.7.1
>>>>>>    -THISAPP    =3D sshfs-fuse-$(VER)
>>>>>> -DL_FILE    =3D $(THISAPP).tar.gz
>>>>>> +THISAPP    =3D sshfs-$(VER)
>>>>>> +DL_FILE    =3D $(THISAPP).tar.xz
>>>>>>    DL_FROM    =3D $(URL_IPFIRE)
>>>>>>    DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
>>>>>>    TARGET =3D $(DIR_INFO)/$(THISAPP)
>>>>>> @@ -40,7 +40,7 @@ objects =3D $(DL_FILE)
>>>>>>      $(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
>>>>>>    -$(DL_FILE)_MD5 =3D 26e9206eb5169e87e6f95f54bc005a4f
>>>>>> +$(DL_FILE)_MD5 =3D 22ac23d05ca7c56fb568627f086374d0
>>>>>>      install : $(TARGET)
>>>>>>    @@ -72,9 +72,7 @@ $(subst %,%_MD5,$(objects)) :
>>>>>>      $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>>>>>>        @$(PREBUILD)
>>>>>> -    @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FIL=
E)
>>>>>> -    cd $(DIR_APP) && ./configure --prefix=3D/usr
>>>>>> -    cd $(DIR_APP) && make $(MAKETUNING)
>>>>>> -    cd $(DIR_APP) && make install
>>>>>> +    @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FIL=
E)
>>>>>> +    cd $(DIR_APP) && meson --prefix=3D/usr builddir && cd builddir &&=
 ninja && ninja install
>>>>>>        @rm -rf $(DIR_APP)
>>>>>>        @$(POSTBUILD)
>>>>
>=20

--===============5182930446041155842==--