From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH v2 1/6] zoneconf.cgi: Change NIC display order, improve code
Date: Mon, 22 Feb 2021 13:47:11 +0000
Message-ID: <409D3EE1-E024-42A8-A14A-BCF421972538@ipfire.org>
In-Reply-To: <156e9dea-e65d-57c3-ea6d-27ce0306f424@leo-andres.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4910232672453239092=="
List-Id: <development.lists.ipfire.org>

--===============4910232672453239092==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

*thumbs up*

Couldn=E2=80=99t agree more.

> On 21 Feb 2021, at 12:14, Leo Hofmann <hofmann(a)leo-andres.de> wrote:
>=20
> Hello Michael,
>=20
> thank you for all your positive feedback and support! I like the working at=
mosphere here very much.
> (Sorry for the "off-topic" mail, but I think this is worth mentioning and a=
ppreciating!)
>=20
> Looking forward to the test results!
>=20
> Best,
> Leo
>=20
> Am 19.02.2021 um 20:26 schrieb Michael Tremer:
>> Hello,
>>=20
>>> On 18 Feb 2021, at 14:36, Leo Hofmann <hofmann(a)leo-andres.de> wrote:
>>>=20
>>> Hi all,
>>>=20
>>> you probably already saw this patchset last month :)
>>>=20
>>> I have implemented your suggestions and decided to resubmit the entire pa=
tchset to keep it coherent.
>>> The patches 1-4 are unchanged. Daniel and Michael have already tested the=
m (thank you very much!).
>>>=20
>>> Patch 5 makes zoneconf use the new zone detection functions in network-fu=
nctions.pl. This also fixes bug #12568!
>>> Patch 6 adds default values to the input fields. I decided to add a defau=
lt VLAN ID as well, because these inputs suffered from the same usability iss=
ue as the STP priority fields.
>>>=20
>>> I'm looking forward to your feedback!
>> Thank you very much for working on this.
>>=20
>> Judging from the code, this looks very good. Nice and tidy and changes are=
 split into small chunks that are very easy to review.
>>=20
>> I will wait for some more people to give any feedback - and hopefully test=
 it live - and merge it.
>>=20
>> Well done!
>>=20
>> -Michael
>>=20
>>> Best regards,
>>> Leo
>>>=20
>>> P.S. @Daniel thanks for your help with re-submitting! I have read through=
 all your emails again and decided that I can submit these patches now.
>>>=20


--===============4910232672453239092==--