Wrong 'pathname to specified program' for 'killproc' in some init-files!?

[Matthias Fischer <matthias.fischer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

Hi,

while searching for something else I found this:

Usage for the 'killproc'-function in '/etc/init.d/'-files should be (cited):

"# Function - killproc  [-p pidfile] pathname [signal]
#
# Purpose:
#
# Inputs: -p pidfile, uses the specified pidfile
#         pathname, pathname to the specified program
..."

But in the 'init'-files for 'dhcp', 'dhcrelay' and 'rndg' there is the
PROGRAMname and in 'snort'-file '/var/run' is given. The latter leads to
an error (FAIL) if both 'green0' and 'red0' are enabled and should be
both stopped:

...
killproc -p /var/run/dhcpd.pid /usr/sbin/dhcpd
                                        ^^^^^^
...
killproc -p /var/run/dhcrelay.pid /usr/sbin/dhcrelay
                                           ^^^^^^^^^
...
killproc -p /var/run/rngd.pid /usr/sbin/rngd
                                       ^^^^^
...
killproc -p /var/run/snort_$DEVICE.pid /var/run
                                       ^^^^^^^^

IMHO, all these should be changed to "pathname to the specified program"
as cited above ('/usr/sbin').

Can anyone please confirm?

Best,
Matthias