Re: DDNS: add new Provider key-sytems.net (domaindiscount24)

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]

Hello Christof,

> On 28 Nov 2019, at 10:45, Christof Weniger <ChristofWeniger(a)gmx.at> wrote:
> 
> Hi,
> 
> I hope this is the correct way to submit this patch.

Yes, you found the right place.

It would have been better to post the patch inline (and not as an attachment), so that I could have commented on it.

> https://www.domaindiscount24.com/ has its own ddns service runnning,
> which (for me) gets rid of the necessity of having to use an extra
> service for that.
> 
> I tested the following patch on my system at home, and attached it to
> this mail.
> 
> I started my quest at the community forum:
> https://community.ipfire.org/t/adding-new-ddns-provider/428/2
> 
> Christof
> 
> 
> 
> 
> 
> <add_key_systems_ddns.patch>

I will make an exception here now and still give you my thoughts :)

It looks like this is very close to the DynDNS protocol, so you can re-use that as some other providers do.

Unfortunately this provider has no list of any possible responses - or maybe I have overlooked it. That can however be tested to check if those are still compatible with DynDNS.

Finally, you are setting the IP addresses to “auto” which probably is not a good idea. I would prefer that it is explicitly being set. There is a function for it that finds out which one is the correct IP address.

In the end I think this provider could look like “myonlineportal”: https://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/providers.py;h=661fbcc57a5aecba0d958ec05c26296b3cef0d70;hb=HEAD#l1274

Best,
-Michael