public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Re "linux-firmware: ship needed config txt files." commit
Date: Fri, 29 Nov 2024 14:06:11 +0000	[thread overview]
Message-ID: <425EC3E1-03ED-4093-8162-88C717838819@ipfire.org> (raw)
In-Reply-To: <ac05b318-b4ff-438c-b97a-2d1af3cf8228@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hello,

If I may chime in…

Some hardware seems to load firmware and then a configuration file which has some sort of settings. We didn’t ship those.

To make things easier, we should simply ship everything. Disk space utilisation of /lib/firmware is already through the root and so some extra text files probably won’t hurt.

The script that checks for changes does not seem to filter out anything, so we don’t need any changes.

-Michael

> On 29 Nov 2024, at 11:50, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Arne,
> 
> That was me I am afraid. I remember seeing all the text files in the rootfile and thought that those are not firmware files and so would not be needed.
> 
> Obviously my assumption about those files not being needed was very wrong.
> 
> I will make sure not to do the same thing again.
> 
> It should be unlikely to happen again as @Michael has added the find-linux-firmware-changes tool to the system now which should help make sure I don't remove needed files.
> 
> Apologies for my error. I hope it didn't cause you too many problems with the builds and testing before you discovered it.
> 
> Regards,
> 
> Adolf.
> 


      reply	other threads:[~2024-11-29 14:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29 11:50 Adolf Belka
2024-11-29 14:06 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=425EC3E1-03ED-4093-8162-88C717838819@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox