Re "linux-firmware: ship needed config txt files." commit

Re "linux-firmware: ship needed config txt files." commit

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

Hi Arne,

That was me I am afraid. I remember seeing all the text files in the rootfile and thought that those are not firmware files and so would not be needed.

Obviously my assumption about those files not being needed was very wrong.

I will make sure not to do the same thing again.

It should be unlikely to happen again as @Michael has added the find-linux-firmware-changes tool to the system now which should help make sure I don't remove needed files.

Apologies for my error. I hope it didn't cause you too many problems with the builds and testing before you discovered it.

Regards,

Adolf.

Re: Re "linux-firmware: ship needed config txt files." commit

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hello,

If I may chime in…

Some hardware seems to load firmware and then a configuration file which has some sort of settings. We didn’t ship those.

To make things easier, we should simply ship everything. Disk space utilisation of /lib/firmware is already through the root and so some extra text files probably won’t hurt.

The script that checks for changes does not seem to filter out anything, so we don’t need any changes.

-Michael

> On 29 Nov 2024, at 11:50, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Arne,
> 
> That was me I am afraid. I remember seeing all the text files in the rootfile and thought that those are not firmware files and so would not be needed.
> 
> Obviously my assumption about those files not being needed was very wrong.
> 
> I will make sure not to do the same thing again.
> 
> It should be unlikely to happen again as @Michael has added the find-linux-firmware-changes tool to the system now which should help make sure I don't remove needed files.
> 
> Apologies for my error. I hope it didn't cause you too many problems with the builds and testing before you discovered it.
> 
> Regards,
> 
> Adolf.
>